angryhacker / c_plus_plus_exercise Goto Github PK

`buildBaseData()方法中第37行的while((sex == 1 || sex == 0) && !fin.eof())这个循环是个死循环

我对C++的了解不多 上次学习它还是在两年前
但在学生管理系统中 src/Student.cpp 下 我觉得存在部分冗余结构
如:
for(int i=0;i<degree.size();++i) { long m_Num = degree[i]; int pos = getmPosition(m_Num); string name = getNameAtIndex(pos); int sex = getSexAtIndex(pos); int age = getAgeAtIndex(pos); string addr = getAddrAtIndex(pos); cout<<setw(8)<<" "<<setw(10)<<m_Num<<setw(10)<<name<<setw(10)<<getC_MajorDepName(); if(!sex) cout<<setw(5)<<"男"; else cout<<setw(5)<<"女"; cout<<setw(5)<<age<<setw(10)<<addr<<endl; fout<<m_Num<<" "<<name<<" "<<getC_MajorDepName()<<" "<<sex<<" "<<age<<" "<<addr<<endl; } fout<<endl<<"不能获得主修学位学生："<<endl; cout<<endl<<endl<<setw(20)<<" "<<"不能获得主修学位学生："<<endl<<endl; cout<<left; cout<<setw(8)<<" "<<setw(10)<<"学号"<<setw(10)<<"姓名"<<setw(5)<<"性别"<<setw(5)<<"年龄"<<setw(10)<<"地址"<<endl; for(int i=0;i<failDegree.size();++i) { long m_Num = failDegree[i]; int pos = getmPosition(m_Num); string name = getNameAtIndex(pos); int sex = getSexAtIndex(pos); int age = getAgeAtIndex(pos); string addr = getAddrAtIndex(pos); cout<<setw(8)<<" "<<setw(10)<<m_Num<<setw(10)<<name; if(!sex) cout<<setw(5)<<"男"; else cout<<setw(5)<<"女"; cout<<setw(5)<<age<<setw(10)<<addr<<endl; fout<<m_Num<<" "<<name<<" "<<sex<<" "<<age<<" "<<addr<<endl; }
或许可以抽调成一个方法(函数)
`// 提取重复的代码到方法(函数)中
void printStudentInfo(long m_Num, int pos) {
string name = getNameAtIndex(pos);
int sex = getSexAtIndex(pos);
int age = getAgeAtIndex(pos);
string addr = getAddrAtIndex(pos);

cout << setw(COLUMN_WIDTH) << " " << setw(COLUMN_WIDTH) << m_Num << setw(COLUMN_WIDTH) << name;

if (!sex) cout << setw(COLUMN_WIDTH) << "男";
else cout << setw(COLUMN_WIDTH) << "女";

cout << setw(COLUMN_WIDTH) << age << setw(COLUMN_WIDTH) << addr << endl;
fout << m_Num << " " << name << " " << sex << " " << age << " " << addr << endl;

}

// 使用函数来打印学生信息，减少重复代码
for (int i = 0; i < degree.size(); ++i) {
long m_Num = degree[i];
int pos = getmPosition(m_Num);
printStudentInfo(m_Num, pos);
}

// 使用函数来打印失败学位的学生信息，减少重复代码
for (int i = 0; i < failDegree.size(); ++i) {
long m_Num = failDegree[i];
int pos = getmPosition(m_Num);
printStudentInfo(m_Num, pos);
}`

hh