Code Monkey home page Code Monkey logo

Comments (2)

elyograg avatar elyograg commented on June 27, 2024

With the following diff, it works:

diff --git a/certbot-he-hook.sh b/certbot-he-hook.sh
index f65a761..1eae4aa 100755
--- a/certbot-he-hook.sh
+++ b/certbot-he-hook.sh
@@ -56,7 +56,7 @@ if [ -n "$HE_USER" ] && [ -n "$HE_PASS" ]; then
   HE_COOKIE=$( \
     curl -L --silent --show-error -I "https://dns.he.net/" \
       | grep '^Set-Cookie:' \
-      | grep -Eo 'CGISESSID=[a-z0-9]*')
+      | grep -Eo '[a-z0-9]*=[a-z0-9]*' | head -n1)
   # Attempt login
   curl -L --silent --show-error --cookie "$HE_COOKIE" \
     --form "email=${HE_USER}" \
@@ -92,11 +92,10 @@ STRIP_COUNTER=1
 # Walk through all possible zone names
 while true; do
   ATTEMPTED_ZONE=$(echo "$CERTBOT_DOMAIN" | cut -d . -f ${STRIP_COUNTER}-)
-
   # All possible zone names have been tried
   if [ -z "$ATTEMPTED_ZONE" ]; then
     echo "No zone for domain \"$DOMAIN\" found." 1>&2
-    return 1
+    break
   fi

   # Take care of "." and only match whole lines. Note that grep -F

from certbot-he-hook.

elyograg avatar elyograg commented on June 27, 2024

My fix for line 99 (See issue #10 too) here may not be right. "exit 1" may be the right way to go.

from certbot-he-hook.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.