Wrong XML tag matched and replaced about vim-matchup HOT 5 CLOSED

Thank you for the very clear description; reproduced. 46f411c should fix it.

In retrospect, auto-transmute is quite dangerous because in some cases it is impossible to know what the desired change was. I am considering adding a mapping to trigger it instead.

from vim-matchup.

I agree, it can be dangerous. Still, I find it useful and will continue to use it.

in some cases it is impossible to know what the desired change was
Could the plugin identify such cases? If so it could prompt for directions or hold the change with a warning.

from vim-matchup.

Unfortunately this issue still happens with different XML test input.

        <variable>x</variable>
        
        <action>a ''</action>

which is

00000000: 0a20 2020 2020 2020 203c 7661 7269 6162  .        <variab
00000010: 6c65 3e78 3c2f 7661 7269 6162 6c65 3e0a  le>x</variable>.
00000020: 2020 2020 2020 2020 0a20 2020 2020 2020          .       
00000030: 203c 6163 7469 6f6e 3e61 2027 273c 2f61   <action>a ''</a
00000040: 6374 696f 6e3e 0a0a                      ction>..

To reproduce you need to place the cursor on the first "a" of <variable> then press j d d to end up with

        <variable>x</action>
        <action>a ''</action>

Sorry for keeping you busy on this.

from vim-matchup.

Thanks! ef17dcb should do it, hopefully it is not too careful now to miss actually useful text changes.

Could the plugin identify such cases?

I think it is likely possible with text-properties, which is a new feature in vim 8.1.0694, but still being worked on. However, if I go down this route, I won't be able to support old vim.

from vim-matchup.

This fix looks good here. Thank you!

from vim-matchup.