Code Monkey home page Code Monkey logo

Comments (8)

vsudilov avatar vsudilov commented on June 3, 2024

Thanks for the report, will look into a fix. In the meantime you can specify a start kwarg and it should work.

from ads.

vsudilov avatar vsudilov commented on June 3, 2024

Looks like the behaviour was introduced upstream @ romanchyla/montysolr@ca2d423

@aaccomazzi , this change breaks this client's functionality -- should we revert cursorMark?

from ads.

aaccomazzi avatar aaccomazzi commented on June 3, 2024

Ugh, I didn't see this coming... The reasoning behind the error is explained here: http://lucene.472066.n3.nabble.com/cursorMark-and-timeAllowed-are-mutually-exclusive-td4214685.html
@romanchyla what do you think we should do? The cursorMark implementation is more efficient and robust than offset queries, but removing the timeout is def not ideal.

from ads.

andycasey avatar andycasey commented on June 3, 2024

from ads.

aaccomazzi avatar aaccomazzi commented on June 3, 2024

Not according to the documentation. Seems to be a somewhat anal choice made to guarantee the presence of a token no matter what.

from ads.

romanchyla avatar romanchyla commented on June 3, 2024

from ads.

aaccomazzi avatar aaccomazzi commented on June 3, 2024

So I suggest we remove timeAllowed till we sort this out on our end, otherwise the client library is broken.

from ads.

vsudilov avatar vsudilov commented on June 3, 2024

Cool, if you need us to make any changes related to this in the future please reopen or create a new issue

from ads.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.