TypeError: 'module' object is not callable in top-cited-astronomers.py about ads HOT 8 CLOSED

Hi,

That script hasn't been updated since the api compatibility update a few months ago. On the bright side, updating it is straightforward ;)

from ads.

Is there a documented way of making said straightforward change ? :)

from ads.

The API is (hopefully) documented sufficiently well in the README.md to update those example scripts. No worries if you'd rather not make this changes -- I didn't mean to imply expectation on my part.

from ads.

No worries. I was hoping to use this module for a dotastro hackday. Hopefully I can create a new script by following along the example on the homepage.

Thanks !

from ads.

It does not seem trivial to change: Changing the line

most_cited_papers = ads.search(sort="citations", filter="database:astronomy", rows=200)

to

most_cited_papers = list(ads.SearchQuery(sort="citations", rows=200))

does not work since q must not be empty.

from ads.

Hi,

specifying q="*" should do the trick.

from ads.

This should be fixed in #51. Please re-open if there are further issues.

from ads.

Works for me. Thanks for the fix

from ads.