[idea] Return a promise in getInitialStateAsync about react-async HOT 8 CLOSED

Good idea, you can send a PR :D

from react-async.

I do have a PR for this but it would require a polyfill like es6-promise or something for cross-browser support. Otherwise only modern browsers have native Promise

from react-async.

Does it really require depending on promise library?

What about something like this:

var ReactAsyncWithPromisesMixin = {
  getInitiatStateAsync: function(cb) {
    this.getInitialStatePromise().then(
      function(result) { cb(null, result); },
      function(err) { cb(err); }
    );
  }
}

from react-async.

that definitely work, but where would getInitialStatePromise come from though? If that's implemented by user then wouldn't getInitialStateAsync be redundant?

from react-async.

What about...

var promise = this.getInitialStateAsync(cb);

if (promise && typeof promise.then === 'function') {
    promise.then(cb.bind(cb, null), cb);
}

It would be inside the #wrap callback of this line

from react-async.

yeah I think that's more like it

from react-async.

@longlho yes, in my example there's a separate mixin for promises which requires implementing a different method getInitialPromiseState where getInitialStateAsync already implemented.

Checking getInitialStateAsync for a resulted value is a good idea. That way we reduce API surface by not having an additional mixin.

from react-async.

👍

from react-async.