Code Monkey home page Code Monkey logo

Comments (11)

andrew13 avatar andrew13 commented on September 24, 2024

The username field is in the form. What url are you getting this at?

Both admin/users/create and users/create are working for me.

from laravel-4-bootstrap-starter-site.

richlove1 avatar richlove1 commented on September 24, 2024

Apologies Andrew, I think I've thrown you off course here, it's not the create routes it's the profile update/user index routes (e.g. www.example.com/user). Try submitting this form? It has no username field and it also submits to postIndex() which seems quite tailored for the create submission (which is why i was wondering if there should be a postCreate() or postIndex() is supposed to handle user registration and user updates.

from laravel-4-bootstrap-starter-site.

andrew13 avatar andrew13 commented on September 24, 2024

Ah, got it. I thought I had removed that page. I'll patch it up.

from laravel-4-bootstrap-starter-site.

richlove1 avatar richlove1 commented on September 24, 2024

Great work, will have a look at this now. Just to let you know you have a duplicate form close tag in / app / views / site / user / index.blade.php

from laravel-4-bootstrap-starter-site.

richlove1 avatar richlove1 commented on September 24, 2024

And ln57 of UserController.php should be

            ->with( 'notice', Lang::get('user/user.user_account_updated') );

not

            ->with( 'notice', Lang::get('user.user.user_account_updated') );

from laravel-4-bootstrap-starter-site.

richlove1 avatar richlove1 commented on September 24, 2024

This still redirects to user.login even when the user is updating their details? They're already logged in so should probably direct to their profile page or something?

from laravel-4-bootstrap-starter-site.

richlove1 avatar richlove1 commented on September 24, 2024

Also, the update form only updates if the user enters their password/confirm password, that's probably not desired behaviour is it? They shouldn't have to do that if they're already logged in.

If they don't enter their password, they updates don't take effect but you still get the message 'user account updated'.

(sorry for all the comments, should I raise new issues?)

from laravel-4-bootstrap-starter-site.

richlove1 avatar richlove1 commented on September 24, 2024

There is also an error on submission of the user/create form (using {{ Confide::makeSignupForm()->render() }} to generate the form)

The error is:

Missing argument 1 for UserController::postIndex()

Because that function is now expecting a User object? I think the function still has dual purposes (probably by design) of handling user creation and user updates but isn't quite handling both (either) at the moment.

from laravel-4-bootstrap-starter-site.

richlove1 avatar richlove1 commented on September 24, 2024

Any thoughts?

from laravel-4-bootstrap-starter-site.

richlove1 avatar richlove1 commented on September 24, 2024

I see you've been doing fixes.... that relate to this also 👍

from laravel-4-bootstrap-starter-site.

andrew13 avatar andrew13 commented on September 24, 2024

Yeah I'll have this updated shortly when I merge the phpunit test branch.

from laravel-4-bootstrap-starter-site.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.