Code Monkey home page Code Monkey logo

Comments (2)

andrewbrereton avatar andrewbrereton commented on July 18, 2024

Hi @moulai. Wow, this is great. Thank you.

General feedback:

Please create one branch and one pull request per feature. I am happy to checkout your branch, add tests, add docs, etc, and review the pull request prior to merging.

1. Add option to create multiple events without schedule icon.

I'm not sure if I understand this feature properly, can you please elaborate? Perhaps we use different calendar apps so we see different things. If you wish, provide a screenshot to help me to understand.

2. Customizable status icons.

Yes, this is a good feature. I presume this would add four new settings to choose either the default emoji or enter custom text for TaskStatus.Cancelled, TaskStatus.Done, TaskStatus.InProgress and TaskStatus.ToDo.

3. Parse [startTime::], [length::] and [endTime::] properties (Tasks & DataView format of time).

This plugin already has support for Obsidian Tasks dataview format however the labels you mentioned (eg: startTime) is different from the Obsidian Tasks labels. Is this to support another format?

4. Save calendar to private server.

I was envisioning adding support for S3, SFTP, etc. They would be additional *Client.ts classes. Your suggestion seems like a good client to add. I'm not sure how popular it is, but I'm more than happy to accept it.

5. Bug Fix: All day event.

Thank you :)

from obsidian-to-ical-plugin.

moulai avatar moulai commented on July 18, 2024

Hi @andrewbrereton, thank you for your reply. Here are some additional details and explanations.

1. Add option to create multiple events without schedule icon.

I have uploaded some screenshots showcasing events with (the original multi-events functionality) and without the ⏳ icon. While the original version looks great, I found that having many ⏳ icons can be a bit overwhelming and redundant for my workflow. In the modified version (shown in another screenshot), I have removed the ⏳ icon, resulting in a cleaner look.

My scheduling process involves selecting tasks without specific scheduled dates from the backlog and then assigning them to dates within the current week or month. That is, the events that appear on the calendar are by default "Scheduled."

Perhaps we could add custom functionalities for the "schedule", "due", and "start" icons, similar to Feature 2. This way, there would be no need for a separate option to remove the ⏳ icon! (I can simply set the schedule icon to be empty)

2. Customizable status icons.

I will open a PR for this as soon as possible. It may need your review and modifications on the settings view.

3. Parse [startTime::], [length::] and [endTime::] properties (Tasks & DataView format of time).

I apologize for the confusion, it seems that startTime and endTime are not official Tasks dataview markers (it appears that the official Tasks plugin does not explicitly provide time markers for tasks). However, I have come across many users on the forum using startTime and endTime as task time markers: https://forum.obsidian.md/search?q=startTime.

startTime and endTime are the official time marker formats for the Full Calendar plugin: obsidian-full-calendar

Most importantly, I use obsidian-time-ruler for tasks management (by the way, this is a great plugin). It generates default timestamp markers for Tasks as startTime and Length.

Perhaps this format could be named to "support the time-ruler plugin/the full-calendar plugin"?

4. Save calendar to private server.

Using S3 or SFTP does seem like a more elegant solution!

I think the tool I mentioned is not widely used, but it is easy to deploy (via Docker, lightweight, and resource-efficient), which is why I opted for it. However, I agree that this feature may not be necessary (supporting S3, SFTP would be preferable).

5. Bug Fix: All day event.

I will open a PR for this as soon as possible. I have a question though, is it possible for the original program to generate an event like DTSTART:20240301 \n DTEND:20240301 (which is logically an all-day event but has an incorrect format)? Do we need to implement additional checks in the code for this?

Screenshots for feature 1

from obsidian-to-ical-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.