Can't download default style with nitpick about nitpick HOT 8 CLOSED

Hi @Skrierz. Thanks for this new bug report, thanks for using nitpick on Windows.

I think that problem is due to resolving domain_plus_url in style.fetch_style_from_url.
I don't understand why it's done for but it looks like that problem can occur on Linux too.

The code Path(rest) / url should work on Linux because the URL path separator is the same as the file path separator (/).
But this doesn't work on Windows, because the file path separator is \.

I need to improve this logic and do something generic that can also work on Windows.
I will keep you posted. 😉

from nitpick.

Damn... the quick fix didn't work as I expected.
So I will rewrite that part of the code and let you know.

Thanks for testing it!

from nitpick.

@Skrierz could you try this branch and tell me if it works?

https://github.com/andreoliwa/nitpick/tree/fix-fetch-url
#124

from nitpick.

Hi @andreoliwa.
Thanks for update!

I checked fix and unfortunately it doesn't work. I get pathlib exception:

NotImplementedError: cannot instantiate 'PosixPath' on your system

from nitpick.

@Skrierz could you try again and tell me if it works now?

https://github.com/andreoliwa/nitpick/tree/fix-fetch-url
#124

from nitpick.

@andreoliwa
It works!
Thanks for fix!

from nitpick.

Nice! I will release a new version soon.
Thanks for testing it on Windows!

from nitpick.

🎉 This issue has been resolved in version 0.21.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

from nitpick.