Code Monkey home page Code Monkey logo

Comments (3)

BlinkyStitt avatar BlinkyStitt commented on July 29, 2024 3

I think it needs a check more similar to this line from Rarity.sol: return (spender == owner || getApproved(tokenId) == spender || isApprovedForAll(owner, spender));

from rarity.

KrombopulosMichael avatar KrombopulosMichael commented on July 29, 2024 1

Maybe rarity/rarity.sol's _isApprovedOrOwner function should not be internal.
rariry/rarity_crafting-materials-1.sol has this same problem.

If changed it would enable calling adventure for a bunch of summoners at once for the cellar quest, like in this contract.

from rarity.

onemedicine avatar onemedicine commented on July 29, 2024

Maybe rarity/rarity.sol's _isApprovedOrOwner function should not be internal.
rariry/rarity_crafting-materials-1.sol has this same problem.

If changed it would enable calling adventure for a bunch of summoners at once for the cellar quest, like in this contract.

In fact, this does not prevent bulk behavior, approve can also achieve the bulk target, just a little more trouble and cost increase. Suggest adding the check:https://ftmscan.com/address/0x4a33076916289486cdc975ee28ef4041a5e5702a#writeContract

from rarity.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.