Code Monkey home page Code Monkey logo

Comments (4)

andreaswilli avatar andreaswilli commented on June 26, 2024

Thank you for the kind words.

I like your proposal, because most of the time we're probably interested in complete values only and I've seen many people check for the length in the onChange handler.

You can go ahead and implement it if you want.

As for the naming, I can't think of anything else. So we can go with that, I guess.

from react-verification-input.

caiotracera avatar caiotracera commented on June 26, 2024

Hey, @andreaswilli!
Thank you for the reply! I added this to my doing list, and I'll try to work on that during this weekend.

Just so we can be on the same page: my initial idea was to check if the newInputVal.length is equal to the length. If true, check if the onComplete prop exists and then call it. What do you think about this approach?

if (RegExp(`^[${validChars}]{0,${length}}$`).test(newInputVal)) {
if (onChange) {
onChange?.(newInputVal);
}
setLocalValue(newInputVal);
}

if (RegExp(`^[${validChars}]{0,${length}}$`).test(newInputVal)) { 
   if (onChange) { 
     onChange?.(newInputVal); 
   }
   
   setLocalValue(newInputVal);
   
+   if (newInputVal.length === length) {
+     onComplete?.(newInputVal)
+   }
} 

Let me know if you think there is a better approach!

from react-verification-input.

andreaswilli avatar andreaswilli commented on June 26, 2024

Looks good to me 👍🏼

from react-verification-input.

andreaswilli avatar andreaswilli commented on June 26, 2024

Released v3.3.0

from react-verification-input.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.