lighthouse flag ignored about lighthouse-ci HOT 4 CLOSED

I was going to open a similar issue! I think the config is not ignored, it doesn't throw error even if you pass the budget via config-path, it is just because the code doesn't implement performance-budget checking (see https://github.com/andreasonny83/lighthouse-ci/blob/master/bin/cli#L181-L202)

lighthouse just response result in json format, but it is up to lighthouse-ci to parse it and response to user

from lighthouse-ci.

Thanks, both @grebenyuksv-preply and @foray1010 .
I'm sorry about the unexpected behaviour. I'll try to have a look as soon as I have time and release a patch for the cli.
Alternatively, if you can create a PR with that fix, I'll be more than happy to review it. That will speed up the releasing process for sure.

Thanks again

from lighthouse-ci.

@grebenyuksv-preply

--budget-pass is passed to lighthouse npm module, but is it does not look like it is processed when you are using lighthouse from code.
As of now, you can pass budget configurations as a part of configs like:

{
  "extends": "lighthouse:default",
  "settings": {
    "budgets": [
      {
        "resourceCounts": [
          { "resourceType": "total", "budget": 10 }
          
        ],
        "resourceSizes": [
          { "resourceType": "total", "budget": 100 }
        ]
      }
    ]
  }
}

from lighthouse-ci.

@asmagin fantastic, it worked! I didn't manage to figure that way out from LH docs.

Feel free to close the issue if it makes sense to you.

from lighthouse-ci.