Comments (7)
andli
commented on May 24, 2024
1
Release 1.6.1 out now with your fixes @tarpan2 - have great evening.
from pymkm.
tarpan2
commented on May 24, 2024
These fail aswell, not sure why tbh:
Holy Strength,Eighth Edition,1,,English
Holy Strength,Ninth Edition,1,,English
from pymkm.
andli
commented on May 24, 2024
Yup, Cardmarket does not allow shorter strings than 4 characters in their API calls. Weird. The others I will look into. Thanks for reporting the issue(s)!
from pymkm.
andli
commented on May 24, 2024
I have updated README.md with the relevant info for csv importing. I have also added a fix for card names shorter than 4 characters.
Holy Strength fails because there is a card "Unholy Strength" in the same set that I have trouble matching for in a good way. Will push a fix soon. :)
from pymkm.
tarpan2
commented on May 24, 2024
Thanks a lot for reacting so quickly! Another case that is not working are the flip cards from Innistrad:
Tormented Pariah,Innistrad,4,,English
Village Ironsmith,Innistrad,10,,English
Thraben Sentry,Innistrad,10,,English
Grizzled Outcasts,Innistrad,1,,English
Villagers of Estwald,Innistrad,4,,English
from pymkm.
tarpan2
commented on May 24, 2024
aaand one more:
Surging Aether,Coldsnap,7,,English
from pymkm.
andli
commented on May 24, 2024
Hey, I will fix these too of course. :)
Again, thanks for reporting.
from pymkm.
Related Issues (20)
- Problem in all option HOT 1
- when updating price, check if article is playset HOT 2
- Bug with Yugioh cards
- KeyError: 'isFoil' HOT 13
- Web-based UI HOT 1
- First time user experience HOT 1
- Feature Request HOT 3
- Updating part of the stock HOT 9
- Sometimes not all price updates are applied HOT 1
- Price update crashes on special character HOT 3
- Need beta testers for pymkm 2.0.0 HOT 26
- Failed CS HOT 1
- Problem with inserting stock HOT 3
- Clean up suggestion is not working HOT 2
- Need help installing HOT 1
- Import from list.csv HOT 6
- Is there a way to just get the price of a card given its name? HOT 3
- Error - <Response [403] HOT 3
- Error while search for deals from user HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pymkm.