The TinyPNG option should not exist for incompatible files about vscode-tinypng HOT 4 CLOSED

Hi, sorry for the lack of information about the environment.
My OS: Win10 1909
It was reproduced on VSCode 1.42.1

Hmm Ok, that's weird, but maybe let's do it again together:

Step 1 - Install clean latest release VS Code (eg. portable), but not Insider version
Step 2 - Install your plugin
Step 3 - Check issue

GIF Screencast:

from vscode-tinypng.

Hi @kanlukasz,

that is very weird, because this context menu entry on a file should follow this rule:

https://github.com/andi1984/vscode-tinypng/blob/master/package.json#L80

and thus should only appear on png and jp(e)g files. I tried to reproduce this myself on a PHP file, but I can not see it here (Windows machine). I will try later again on a mac.

In the meantime: Can you check that you are on the latest version 0.3.0 of this extension? So either this when clause is not taken into account at all from your VSCode version (which one is it?) or the file itself represents itself as an image file to VSCode in some way to fullfill this clause.

from vscode-tinypng.

@kanlukasz I figured out the issue and updated the extension to v0.3.1. Can you check whether the bug is still there in that particular version? Otherwise we can close this issue.

Thx again for spotting this issue.

from vscode-tinypng.

Yes, it's ok now :) Thx

from vscode-tinypng.