Add more commands? about l5-repository HOT 18 CLOSED

I see the value in this as well, although the make:validator should go in the validator package. I could contribute too.

from l5-repository.

Yea sure, the command for validator should go into the validator package.

from l5-repository.

I think you should just place a PR. Although I don't know if @andersao prefers it on the master or develop branch.

from l5-repository.

+1.

@ionut-tanasa @Jeroen-G
From what I know. PR quick fixes and small additions to master, completely new functions to develop.
So master would be more suitable for this.

from l5-repository.

Hello guys @ionut-tanasa @Jeroen-G @hiddeco ,

I liked the suggestion and I think it will be great to add new commands . What about the branch , the @hiddeco is right. Rather than new features being sent to branch Develop or create other specific branch .

The contribution of you will be very well accepted ;)

from l5-repository.

@ionut-tanasa, are you gonna make a PR? Otherwise I will make one this week. 

from l5-repository.

@hiddeco please do.

I just started the command for the transformer. Maybe you can do the other one/ones?

from l5-repository.

If you've created a PR-repo you can give others push access to it, so it can be one PR.

from l5-repository.

Check #55.

I gave you push access to the repo.

Now it's basic stuff. Maybe we could specify with which properties the return array from the transformer will be filled. Like the --fillable argument for the Model

from l5-repository.

That is actually a great idea, you just want to copy the column names from the database to the transformer then? Because most transformers contain different names than the database columns do (at least mine do).

from l5-repository.

@andersao I love that you are merging so quick my PRs

I'll make the basic presenter command and pr it. then you could improve it and more features to it

from l5-repository.

And I 'm loving the contribution of you.

from l5-repository.

Just a quick question. I'm trying to understand how to pass variables to the stubs.

In the presenter, obviously, I need to use the transformer class. How do I get the root namespace and pass it to the stub in order to write the exact namespace of the transformer?

I am assuming that the Presenter will use a Transformer with the same name.

So when I run make:presenter MODEL, I assume that you already have a MODELTRansformer created.
Maybe I can check that, if the transformer does not exist I can create it for the user.

So how do I pass the root namespace, i.e. App so on top of the class I can use App\Transformers\MODELTransformer ?

from l5-repository.

Laravel has a trait for this: Illuminate\Console\AppNamespaceDetectorTrait

Then you could use $this->getAppNamespace()

from l5-repository.

Maybe I didn't explain myself very well 😄

I know how to get the app namespace from Laravel. My question was: How do I pass the namespace as $APPNAMESPACE$ to the stub file?

from l5-repository.

If you take a quick look at the Generator.php you can find the getReplacement() function. This loads the replacements for the stub file. You can extend the function in your own generator.

Untested example

    /**
     * Get array replacements.
     *
     * @return array
     */
    public function getReplacements()
    {
        return array_merge(parent::getReplacements(), [
            'appnamespace' => $this->getAppNamespace()
        ]);
    }

from l5-repository.

thank you @hiddeco

@andersao PR done #57

from l5-repository.

Done. Closing

from l5-repository.