Comments (8)
Quick question: what happens if an application is using the ADC?
Original comment by razvanm
on 9 Jun 2011 at 4:21
from tinyos-main.
Oh, everything still works and this isn't a hack -- we're just wiring down to
the bottom of the ADC stack.
If you wire VoltageC like ReprogramGuardC does now, you end up pulling in
Msp430InternalVoltageC, AdcReadNowClientC, AdcReadStreamClientC, AdcReadClientC
and so on down the line However at the end of the day you pull in
Msp430Adc12ClientAutoRVGC, the same thing I used -- that arbitrates access to
the ADC channel for sharing.
The only comment I would make is that it looks like my patch doesn't release
the resource when it's done, so it should be fixed...
Original comment by [email protected]
on 9 Jun 2011 at 4:28
from tinyos-main.
Original comment by [email protected]
on 17 Jun 2011 at 7:40
- Changed state: Accepted
from tinyos-main.
I can confirm that burn from apps/tests/deluge/Blink works fine with this
change. The decrease in ROM I got was 2638 bytes.
Current SVN head:
compiled BlinkAppC to build/telosb/main.exe
41420 bytes in ROM
1454 bytes in RAM
Current SVN head with the patch:
compiled BlinkAppC to build/telosb/main.exe
38782 bytes in ROM
1406 bytes in RAM
As Stephen said, the resource for Msp430Adc12ClientAutoRVGC is never released
by this patch and that needs to be fixed before it gets committed.
Note: I only have one telosb so I was not able to also test the burn-net script.
Original comment by [email protected]
on 26 Jul 2011 at 8:18
from tinyos-main.
Original comment by [email protected]
on 3 Aug 2011 at 4:16
from tinyos-main.
Not sure if the issue referred to in 50 was what I was talking about; as far as
I knew, all that needs to be done is call Resource.release() after reading a
sample; I don't know any bugs in Msp430Adc12ClientAutoRVGC. Here's the patch
that does what I was thinking. This is really only important if you *don't*
reprogram; if you do, it triggers a reboot so no one should ever care.
Original comment by [email protected]
on 3 Aug 2011 at 9:35
Attachments:
from tinyos-main.
The latest version of the patch looks good to me. Feel free to submit it. I
think issue 50 is is just a misunderstanding.
Original comment by razvanm
on 3 Aug 2011 at 2:58
from tinyos-main.
Done!
Original comment by [email protected]
on 3 Aug 2011 at 10:44
- Changed state: Fixed
from tinyos-main.
Related Issues (20)
- [patch] UdpP scribbles to memory it should not. HOT 3
- [patch] IPPacketC uses error return value as offset, resulting in trashed memory HOT 3
- "Make safe" does not work with the CC2420 radio chip HOT 2
- Msp430Adc12ClientAutoRVGC does not release resource. HOT 2
- PowerCycleP__startRadio task in permanent re-post spin HOT 2
- Memory Leaks : When check out some unknow critical option Libcoap allocate memory but never free HOT 3
- TOSSIM PYTHON_VERSION on Ubuntu 11.04 x86_64 HOT 3
- Shimmer I2C with msp430-gcc v4.5.3 HOT 3
- Shimmer PowerSupplyMonitor with msp430-gcc v4.5.3 HOT 2
- msp430 code accessed with bit fields HOT 1
- tos-bsl broken for shimmer family HOT 6
- [patch] CoapUdpServer infinite loop HOT 4
- [patch] CoapUdpServer fails to include the client token in many cases HOT 3
- telosb CC2420X compile error with LPL app HOT 1
- [patch] Incorrect 6lowpan PAN handling HOT 4
- rfxlink TrafficMonitorLayerP time variable shadows global one when compiling with TOSSIM HOT 3
- [patch] RF212 frame receive doesn't always complete SPI transfer HOT 2
- [patch] Dhcp6Client fails to find Status options HOT 2
- [patch] Dhcp6Client issues IPAddress.setAddress() even on RENEW HOT 1
- [patch] Dhcp6Client waits unnecessarily long between ADVERTISE and REQUEST
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tinyos-main.