Implement SkipRegion(off, len int64) about torrent HOT 16 CLOSED

It supports changing priorities, the necessary methods just aren't exposed. This can be added trivially with the current master branch. Your other 2 methods can also be added.

The noprio branch is an experiment that removes the internal priorities that aren't currently exposed, and replaces them with priorities based on the offsets of Torrent Readers, so as to allow more responsive seeking on an incomplete torrent.

from torrent.

I see your downstream issue will require a Torrent.SkipRegion/File.NoDownload method either way. Both master and noprio can support this.

from torrent.

Okay awesome
On Wed, 23 Dec 2015 at 3:10 AM Matt Joiner [email protected] wrote:

I see your downstream issue will require a
Torrent.SkipRegion/File.NoDownload method either way. Both master and
noprio can support this.

—
Reply to this email directly or view it on GitHub
#48 (comment).

from torrent.

Send PR or I'll address this myself in the next few days.

from torrent.

Cool, I'll leave this with you. I was just having a look through the noprio branch and I couldn't see an easy way to add it.

from torrent.

Question relating to this issue, if I created a reader for a torrent, begin reading a particular file and close the reader midway through. Does that region get de-prioritised?

I can see that the reader is nil'd though I wasn't sure the regions are re-prioritised somehow.

I'm just wondering if there's another way to lower priorities.

from torrent.

It does not get de-prioritized. This is one of the reasons for the noprio branch, which will support that. There's no public way to deprioritize currently, it's still a work in progress.

from torrent.

I'm about to merge what should allow for this. If you'd like to do some testing with the priority changes, I'll proceed with implementing the ability to File.Cancel().

from torrent.

Awesome! Will probably have some time tomorrow to test

On Thu, Jan 28, 2016 at 8:14 PM Matt Joiner [email protected]
wrote:

I'm about to merge what should allow for this. If you'd like to do some
testing with the priority changes, I'll proceed with implementing the
ability to File.Cancel().

—
Reply to this email directly or view it on GitHub
#48 (comment).

from torrent.

So skipping regions is now supported via torrent.Reader.Close() ? Or will it be supported when File.Cancel() lands?

from torrent.

Ah, Cancel needs to land.

from torrent.

Cool, will be watching 👀

from torrent.

I've Added File.Cancel(), and Torrent.CancelPieces().

from torrent.

Awesome, will give it a test this weekend 👍
On Fri, 5 Feb 2016 at 1:22 AM Matt Joiner [email protected] wrote:

I've Added File.Cancel(), and Torrent.CancelPieces().

—
Reply to this email directly or view it on GitHub
#48 (comment).

from torrent.

No one else has commented here so I'll assume its all good! Will reopen if I find anything

from torrent.

I added a simple test, seems legit.

from torrent.