Comments (3)
Offending code is somewhere in here: https://github.com/amzn/style-dictionary/blob/v4/lib/utils/deepExtend.js
When deep extending objects, we don't seem to take into account that merging:
{
"test": {
"value": "#ffffff",
"type": "color",
"$extensions": {
"studio.tokens": {
"modify": {
"type": "darken",
"value": ".25",
"space": "srgb"
}
}
}
}
}
with
{
"test": {
"value": "#ff0000",
"type": "color"
}
}
should result in
{
"test": {
"value": "#ff0000",
"type": "color"
}
}
and not in
{
"test": {
"value": "#ff0000",
"type": "color",
"$extensions": {
"studio.tokens": {
"modify": {
"type": "darken",
"value": ".25",
"space": "srgb"
}
}
}
}
}
from style-dictionary.
Hey @jorenbroekema, thank you a lot!
Is V4 already ready for production?
from style-dictionary.
No its API is not yet stable, still a small amount of things coming that I think will be API breaking. It's a bit tricky to answer because V4 already solves a loooot of issues with V3 so staying on V3 might be more problematic than migrating to unstable V4 and doing another small migration to the final V4 when it releases (estimated in June)
from style-dictionary.
Related Issues (20)
- Allow references in metadata for transitive transforms
- Remove reliances (transforms, formats) on CTI token hierarchy (e.g. color/hsl-4)
- Token partially transformed HOT 1
- zsh: command not found: style-dictionary HOT 2
- Style Dictionary crashes with generic error "Name must be a string" when there is a design token without a name HOT 3
- Numeric asset values are quoted HOT 3
- Error with /var/ when using style-dictionary in a Lambda function HOT 1
- RangeError: Maximum call stack size exceeded HOT 2
- DTCG format does not support outputReferences? HOT 2
- Compose UI Multiplatform support HOT 2
- Bug: formatter css/variables outputReferenceFallback does not create Fallback value HOT 1
- Regression in transitive transform from version 3.9.0 HOT 5
- Format errors in some Android transforms? (Style Dictionary + `sd-transforms`) HOT 10
- Token Structure Documentation HOT 1
- How to access FormatterArguments types, etc. HOT 5
- Transform tokens into data set referecing other root variables HOT 3
- Some `buildPath` checks only consider `/` as a separator
- Issue with code formatting / line endings HOT 2
- Can I use getReference or somehow get access to the reference token inside of a transformer? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from style-dictionary.