Comments (2)
Ah, this would explain the issue @ajnonaka reported here - AMReX-Astro/MAESTROeX#124
When we update_unevolved_species
we are still "evolving" those species, just analytically using the other species values.
We could fix this by:
-
write a subroutine
unevolved_rhs
that returns the analytic RHS for the unevolved species by differentiating the analytic update equation inupdate_unevolved_species
and writing it in terms of the RHS for the evolved species. -
add ifdefs for simplified SDC to
network_rhs
to callunevolved_rhs
in addition toactual_rhs
-
add analytic RHS for unevolved species to their advective source terms to get their SDC RHS
from microphysics.
we've eliminated nspec_evolve
from microphysics.
Related Issues (20)
- support dense Jacobian in approx networks HOT 1
- have VODE jacobian caching consider how much rates have changed HOT 1
- JOSS paper
- running with test_sdc_vode_rhs gives an error saying integration failed in net
- CMake support HOT 5
- Enhancing the Helmholtz EOS
- create a eos_rh_t type HOT 1
- Rate tabulation inconsistencies in aprox19, aprox21, iso7 HOT 1
- Uninitialized variables in eos_t HOT 1
- create an nse_interp interface that doesn't compute X
- remove abort_on_failure HOT 1
- treat compiler warnings as errors HOT 3
- fix CMake build on Cray systems
- consider changing rhs() interface in integrator to pass y instead of integrator type HOT 2
- reintroduce the idea of multiple integrators
- switch Strang integration to work with (rho X, rho e) HOT 3
- burn_cell_primordial_chem should test if answer is correct
- what's the purpose of integrate_energy now? HOT 1
- for Strang scale_system are we doing the dedot/de term correctly
- for scale_system, the numerical Jacobian scaling is not correct
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from microphysics.