Issue with suppressed errors and empty error_get_last about byte-stream HOT 13 CLOSED

Which error message do you get with that approach?

from byte-stream.

Found it. Actually it was an unwanted behaviour in my error handler but this still introduces a possible bug as that code is functionally depending on the return code of a registered error handler.

Fact:
If the registered error handler returns "true" on a suppressed error then ResourceOutputStream will not detect broken pipes. The socket will be writeable forever, never be cancelled and a loop could hang and run with 100% CPU

from byte-stream.

@kelunik instead of error_get_last the error is simply passed to your temp error handler. You can then handle the error in the same way as you do already

from byte-stream.

I'm asking because we see behavior with 100% CPU currently if you run something with cluster and add fwrite(STDOUT, "foo"); in the worker, which breaks the IPC channel and makes the parent exit, but the other children will still be alive and 100% CPU then.

from byte-stream.

Yep, that's probably the same or related issue. Currently the IpcLogger in aerys isn't checking for error_get_last at all - that's why the shutting down WorkerProcess hangs forever if there's sth to log at shutdown. The parent closes the IPC sock earlier and the child always gets EPIPE.

For Ipc a better approach was that the parent doesn't close the socket at all. The child should close it when everything is shut down correctly. The parent should just watch for the closed socket to clean everything.

from byte-stream.

@amphp/windows-tester Could any of you please run the current master test suite on Windows and report the results?

from byte-stream.

There were 2 failures:

1. Amp\ByteStream\Test\ResourceOutputStreamTest::testBrokenPipe
   Failed asserting that exception of type "Amp\ByteStream\StreamException" is thrown.

2. Amp\ByteStream\Test\ZlibInputStreamTest::testRead
   Failed asserting that two strings are identical.
   --- Expected
   +++ Actual
   @@ @@
   #Warning: Strings contain different line endings!
   -'foobar content
   +'foobar content

from byte-stream.

@pcrov Can you try again with the commit I just pushed?

from byte-stream.

There was 1 failure:

1. Amp\ByteStream\Test\ZlibInputStreamTest::testRead
   Failed asserting that two strings are identical.
   --- Expected
   +++ Actual
   @@ @@
   #Warning: Strings contain different line endings!
   -'foobar content
   +'foobar content

from byte-stream.

Thanks @pcrov, that test probably needs to be fixed on Windows, but that has nothing to do with this issue, so hopefully this has been fixed. I'll wait for @kelunik to confirm before tagging.

from byte-stream.

@pcrov Does it work now?

from byte-stream.

PHPUnit 6.5.7 by Sebastian Bergmann and contributors.

................................................................. 65 / 70 ( 92%)
.....                                                             70 / 70 (100%)

Time: 1.13 seconds, Memory: 8.00MB

OK (70 tests, 98 assertions)

from byte-stream.

@pcrov Thanks for confirming!

from byte-stream.