Code Monkey home page Code Monkey logo

Comments (8)

rdlowrey avatar rdlowrey commented on May 24, 2024

I usually prefer to do an if (!is_resource($res) || feof($res)) check when testing for liveness...

from byte-stream.

kelunik avatar kelunik commented on May 24, 2024

I'm curious why it happened, it never happened before. And it's not 100% reproducible.

from byte-stream.

kelunik avatar kelunik commented on May 24, 2024

It's really strange. When I put the following code in the line before, it never prints anything, but the warning is still triggered.

if (!\is_resource($stream)) {
    \fwrite(\STDERR, "\n" . $this->trace . "\n\n");
}

from byte-stream.

bwoebi avatar bwoebi commented on May 24, 2024

Question: is $data === '' && !feof($res) ever true? AFAIK, an empty string returned from fread/stream_get_contents should always indicate eof by definiton for layer 4 streams. I'm not sure about tls streams though (as these have overhead not delivered to the reader).

from byte-stream.

bwoebi avatar bwoebi commented on May 24, 2024

By the way, I suspect the issue is related to tls streams and won't ever happen with raw layer 4 streams. Am I correct about this?

from byte-stream.

kelunik avatar kelunik commented on May 24, 2024

I'm pretty sure it happens with TLS streams. I'm not sure whether the warning is because of TLS streams. Might also be because of the new process library.

from byte-stream.

kelunik avatar kelunik commented on May 24, 2024

Ignore what I just said about the process library. As there's no new version of amphp/file / amphp/parallel yet, that isn't even installed by Artax, yet.

from byte-stream.

kelunik avatar kelunik commented on May 24, 2024

This is caused by amphp/parallel when pthreads is enabled.

#0 /home/kelunik/GitHub/amphp/artax/vendor/amphp/parallel/lib/Sync/ChannelledSocket.php:22 Amp\ByteStream\ResourceInputStream->__construct()
#1 /home/kelunik/GitHub/amphp/artax/vendor/amphp/parallel/lib/Threading/Internal/Thread.php:88 Amp\Parallel\Sync\ChannelledSocket->__construct()
#2 /home/kelunik/GitHub/amphp/artax/vendor/amphp/amp/lib/Loop/Driver.php:112 Amp\Parallel\Threading\Internal\Thread->Amp\Parallel\Threading\Internal\{closure}()
#3 /home/kelunik/GitHub/amphp/artax/vendor/amphp/amp/lib/Loop/Driver.php:70 Amp\Loop\Driver->tick()
#4 /home/kelunik/GitHub/amphp/artax/vendor/amphp/amp/lib/Loop.php:76 Amp\Loop\Driver->run()
#5 /home/kelunik/GitHub/amphp/artax/vendor/amphp/parallel/lib/Threading/Internal/Thread.php:99 Amp\Loop::run()
#6 Amp\Parallel\Threading\Internal\Thread->run()

from byte-stream.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.