InvalidWatcherError in ResourceOutputStream about byte-stream HOT 2 CLOSED

confirmed, i get the same

from byte-stream.

There are two flawed cases as far as I see...

We do throw an exception inside send() after:

• close() has been called
• end() has been called and the last message has been successfully sent

We do not throw an exception inside send() after:

• end() has been called, but the last message has not been sent yet => should cause a watcher on a closed resource (Bad. May corrupt event loop as well or (typically) trigger an assertion failure: $written !== false).
• fwrite() returns 0 while being the the first call to it within that onWritable loop. The promise is failed and the watcher cancelled. => Will trigger an InvalidWatcherError (this bug)

What is the expected behavior in the last two cases?

For the first case I think we can just throw \Error for trying to write to a self-end()ed stream.

For the latter case we should immediately return new Failure(new StreamException("Failed to write to socket: read watcher already closed due to previous write failure")) (not throw!).

from byte-stream.