Code Monkey home page Code Monkey logo

Comments (6)

trowski avatar trowski commented on August 28, 2024 2

@bwoebi After thinking about this, I realized an app might have a IO, timer, or signal that continually throws that might block another watcher from ever executing that would stop the cycle. I'll update everywhere watcher callbacks are invoked to be wrapped by their own try / catch blocks and continue the tick after calling the loop error handler.

from amp.

trowski avatar trowski commented on August 28, 2024

That try / catch block catches exceptions thrown from any watcher invocation, not just defers, as it is also around the call to dispatch. Any watcher callback throwing an exception effectively immediately ends the tick. In this way defers are handled the same as any other watcher.

from amp.

kelunik avatar kelunik commented on August 28, 2024

It makes handling easier, but it won't execute any I/O watchers if there's always one defer throwing.

from amp.

trowski avatar trowski commented on August 28, 2024

I can't imagine that happening in an actual app.

from amp.

kelunik avatar kelunik commented on August 28, 2024

Same here, that'd be an extreme edge case, but it might happen, as we use Loop::defer to rethrow errors from promises.

from amp.

bwoebi avatar bwoebi commented on August 28, 2024

I see no reason why this shouldn't be changed...

from amp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.