Crashes with the system cbc about limp-cbc HOT 4 CLOSED

Hi! I'm glad you like it. ILP is really interesting.

Ah, I suspect we've never tested the non-embedded flag with different versions. It's probably using the local header file (2.8.6) with your system implementation (2.9.8), and because it's C++ there's more likely to be private implementation stuff inside the header files. If the parts of the public C++ API we're using hasn't changed between 2.8.6 and 2.9.8, we should be able to support 2.9.8 by using the system header files instead.

I think this should be easy enough to fix, but don't have a VM set up or multiple versions of CBC installed. If I push a change, are you keen to test it?

I think to fix this, we just need an #if inside our Cbc.cpp (the C wrapper around the C++):

#if CBC_EMBEDDED
#include "./coin/CbcModel.hpp" // local
#include "./coin/OsiClpSolverInterface.hpp"
#else
#include <coin/CbcModel.hpp> // system
#include <coin/OsiClpSolverInterface.hpp>
#endif

Unfortunately, I don't know how to specify "include coin/CbcModel.hpp, but not the local one" – but I think we can just rename the local coin implementation directory to coin-local and include from coin-local or coin.

from limp-cbc.

Thanks for the quick response!

Sure, I am happy to test patches.

Unfortunately, I don't know how to specify "include coin/CbcModel.hpp, but not the local one"

Couldn't you achieve this by manipulating include-dirs? Is local coin/CbcModel.hpp picked up because it's inside cbits and cbits is in include-dirs? In that case, perhaps moving coin out of cbits (e.g. to the top level) would help?

from limp-cbc.

I've changed it to use pkgconfig-depends to add coin/ to the include-dirs and now we can just #include <CbcModel.hpp>. I tried with 2.9.9 from my system and it seems to work.

Give this a go:
c2d7fce

from limp-cbc.

Works now, cheers!

from limp-cbc.