Code Monkey home page Code Monkey logo

Comments (14)

amake avatar amake commented on May 23, 2024 1

Fira Go looks nice, but it's not on Google Fonts, and I don't think it's appropriate for bundling in the app itself (as a proportional font I don't think it's what most people, myself included, would want by default).

I will see if it's feasible to implement dynamic loading like the Google Fonts Flutter package does, but if not then I'm going to have to say no to anything

  • not in Google Fonts, or
  • not appropriate to be the single default bundled font (which is currently Fira Code)

from orgro.

amake avatar amake commented on May 23, 2024 1

The TestFlight build (1.7.0) is still in review. You'll get a notification when it's available.

from orgro.

oatmealm avatar oatmealm commented on May 23, 2024 1

Looks great! Thanks a lot.

from orgro.

oatmealm avatar oatmealm commented on May 23, 2024 1

Are you satisfied with FiraGO enough that we can close the ticket?

Yes. It's good. Thank you!

from orgro.

amake avatar amake commented on May 23, 2024

Orgro lets you select a font to use as the "primary" font (from a selection of monospaced fonts from Google Fonts) but characters not covered by that font will fall back to whatever the OS provides.

For instance you can see in the Supported Features > Tables section of the manual there is some Japanese text in the table; I don't believe any of the Google Fonts monospace fonts cover Japanese, so that is falling through to the OS's font.

I will see if I can influence the font family type chosen as fallback (e.g. on the level of mono vs serif vs sans), but I won't be doing these:

  • Embed script-specific fonts
  • Specify script-specific font families

from orgro.

amake avatar amake commented on May 23, 2024

Also right now I only offer monospaced fonts because there are just too many fonts in Google Fonts. If Google Fonts offers a better font for your use case, please let me know and I can think about adding that.

(Google Fonts are downloaded dynamically, so it doesn't bloat the app binary.)

from orgro.

oatmealm avatar oatmealm commented on May 23, 2024

If Google Fonts offers a better font for your use case, please let me know and I can think about adding that.

I'm not sure, but I think that in Linux a good proportional font that has good Unicode coverage and is often used for documents is Liberation... there's also Google's Noto family that's broken down by script... including Hebrew, Arabic and almost anything else.

I understand monospace as a choice for org, but the fact that it's not serif is sort of painful in Hebrew at least.

Regardless, it's so wonderful to be able to easily display my org notes on my iPhone and iPad for study etc. 👍

from orgro.

amake avatar amake commented on May 23, 2024

I should have been clearer: Google Fonts offers a package for Flutter that allows dynamically downloading and applying (almost) any of the fonts here: https://fonts.google.com/

I can, in principle, offer (almost) any of the fonts on the above site. The reason I don't is, as I mentioned before, because there are just too many to choose from, and I don't want to make a really specialized UI just for selecting the font.

So currently I simply filter the list to show only monospaced fonts, because I figured most people would want to use monospaced fonts for viewing org documents.

I don't want to bundle any actual font files in the app because

  1. They bloat the app's binary size
  2. There's no one-size-fits-all choice

So for instance I won't offer Liberation because it's not offered on Google Fonts.

The versions of Noto on Google Fonts don't appear to support Hebrew.

There are, however, several Hebrew-supporting fonts available.

Feel free to look through them and give me the name of one or two (say, a serif and a sans) and I can include those.

from orgro.

oatmealm avatar oatmealm commented on May 23, 2024

Yes. Understood.

Looking at google fonts, it doesn't offer many of the fonts that are installable on Linux, where you can find repackaged Noto Sans Hebrew, Noto Sans Arabic etc.

Also, looking at their selection of Hebrew fonts, it doesn't even include the most popular free font collection "Culmus"... so I'm not sure.

There are iOS apps by the way, like Texpad, that offer selective download of components and fonts. I guess they're reusing some existing TeX distro for this, but it also means they have more control. I don't know if it's something you have the bandwidth to deal with (in term of your time).

from orgro.

oatmealm avatar oatmealm commented on May 23, 2024

FiraGO

BTW I came across this variable pitch variant of Fira. Seems to be sans but with good basic Unicode coverage.

Based on the Fira Sans 4.3 glyph set, FiraGO now supports Arabic, Devanagari, Georgian, Hebrew and Thai. With this script support, FiraGO catches up with other globally extended and free typefaces such as Noto.

https://bboxtype.com/typefaces/FiraGO

from orgro.

amake avatar amake commented on May 23, 2024

I had to make a whole package to do it, but I added dynamic loading of FiraGO.

I just submitted the build to TestFlight, so please let me know if this meets your needs.

from orgro.

oatmealm avatar oatmealm commented on May 23, 2024

I had to make a whole package to do it, but I added dynamic loading of FiraGO.

Hi! I've installed it via TestFlight and I can see Fira code and mono, but not firago...

from orgro.

amake avatar amake commented on May 23, 2024

The build is now on TestFlight.

from orgro.

amake avatar amake commented on May 23, 2024

Are you satisfied with FiraGO enough that we can close the ticket?

from orgro.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.