Comments (1)
amaidah
commented on June 19, 2024
Thanks, merged the fix. There may be a potential followup where in your second example, can you you have Xmas start in one zone and compared across a different zone where it's not yet Xmas? Is it a potential issue in comparisons?
Thinking aloud, if a business is global and has started Xmas in one region and someone is checking if it's xmas in another region where it is not yet Xmas, DateTime.now() would not match the day so I think it's probably fine.
from luxon-business-days.
Related Issues (12)
- make getEasterMonthAndDay function available in npm/yarn HOT 4
- plusBusiness does not retain time zone in some cases HOT 4
- Typescript support HOT 10
- Luxon 2.0 HOT 4
- ESM support
- Cannot resolve Symbol `DateTime` HOT 2
- Support for varying working weeks based on region? HOT 4
- Allow `plusBusiness` etc to accept a custom holiday matcher as param HOT 2
- Add tests that verify methods of comparison work with different methods of `DateTime` creation
- Registering custom holidayMatcher is not working. HOT 2
- plusBusiness not giving consistent results
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from luxon-business-days.