Code Monkey home page Code Monkey logo

Comments (7)

alvatip avatar alvatip commented on June 12, 2024

Thanks for noticing, I will take a look at that

from nordzy-icon.

alvatip avatar alvatip commented on June 12, 2024

Hey @Readf0x,
I was wondering which theme are you using ?
Don't ask me why, that was some years ago, and I was less experienced, but I encountered an issue and I chose not to use currentColor, instead I am changing the color when installing a theme.
So symbolic icons in Nordzy are set to Nord0(dark) and symbolic icon in Nordzy-dark are set to Nord6 (light)

PS: Yes, I know that the name are counter intuitive, when I named them I thought Nordzy for overall light theme (=> so dark symbolic icons) and Nordzy-dark for overall dark theme (=> so light symbolic icons) 😛

from nordzy-icon.

Readf0x avatar Readf0x commented on June 12, 2024

I'm using the Nordic theme for my GTK theme. Other than that I'm using qt5 settings to manually change the colors to match the nord theme, since there really aren't that many qt themes online.

I didn't know there was a Nordzy dark, actually... That would've saved me so much time... 🤦

from nordzy-icon.

Readf0x avatar Readf0x commented on June 12, 2024

Upon further inspection, this affects GTK apps as well.

image

I would assume that when text is using the selected color, so should symbolic icons. However I'm no expert on GTK, so it's entirely possible I'm wrong.

from nordzy-icon.

alvatip avatar alvatip commented on June 12, 2024

Damn!
Thanks for reporting it, I will try using currentColor, hoping it solve the issue 😛

from nordzy-icon.

alvatip avatar alvatip commented on June 12, 2024

I believe I found the fix, I don't think I will have time to do it today nor this weekend, so it will most likely be on Monday

from nordzy-icon.

alvatip avatar alvatip commented on June 12, 2024

@Readf0x ,
I brought some changes to the icons,
Screenshot_20230719_134849
Here is what I see in kvantum, using Nordic theme, maybe you can confirm that changes in the last commit were indeed successful ?
Thanks

Edit: I should mention that I was able to reproduce the issue in kvantum which is why I used it as a reference to make the modification

from nordzy-icon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.