Comments (4)
Attached is a patch that eliminates this problem by adding a setParentModule
method to
the Mvp4gModule interface. The parameter is a Mvp4gModule which is casted back
to the
proper type in child module method definition. Rather than using the parameter
to
determine the parent module type, it is saved into ChildModuleElement when they
are
loaded.
Original comment by [email protected]
on 19 May 2010 at 7:39
Attachments:
from mvp4g.
Thanks for the patch.
I have a question about your correction. For a child module, in
Mvp4gConfiguration.java, findParentModule will always return null since a child
module won't have an annotation @ChildModule with its class. Then you won't
have
access to parent module & parent event bus classes and won't be able to do the
right
cast. Am I missing something?
Original comment by [email protected]
on 20 May 2010 at 2:50
from mvp4g.
Indeed you are correct. I guess it was a bit too late to be coding... Anyway I
have
attached a patch that should be correct. This patch finds the parent type by
searching
through the annotation scan results for a class annotated with @ChildModules
containing
the module in question.
Original comment by [email protected]
on 20 May 2010 at 4:02
Attachments:
from mvp4g.
Included in the last snapshot
Original comment by [email protected]
on 8 Jun 2010 at 10:19
- Changed state: Fixed
from mvp4g.
Related Issues (20)
- Feature Request -- GWT 2.5 Closure Compiler (optional flag set) HOT 1
- Multiple presenter failed to inject itself to the enclosed reverse view HOT 8
- Error when running my project which is upgraded from GWT 2.4 to GWT 2.5 HOT 4
- GWT dev-mode ignores @Singleton for views, but production mode works HOT 3
- Support on checked exceptions for events HOT 1
- First instance of Multiple Presenter not created if "handlers" attribute used HOT 5
- Could not work with google-gin 2.0 HOT 22
- Error should be thrown if historyOnStart is set to true for child module. HOT 1
- Enable setting a loader for root module HOT 2
- Use of historyConvertor overrides navigationEvent = false in @Event annotation HOT 4
- Splitter, ReverseResizeComposite, and LazyPresenter/View NullPointer HOT 5
- @History annotation propagation
- Child module is not passing through parent filter HOT 1
- Mvp4g with Deferred Binding not creating expected rebind results HOT 2
- Patch for update mvp4g for last gin 2.1.1 and gwt 2.5.1 HOT 2
- Multiple Presenter, Multiple module HOT 2
- NavigationConfirmation is triggered after History has been updated HOT 1
- mvp4g can't be build with GWT 2.7 HOT 1
- GWT exporter cast exception from GWT.create; Tried to use mvp4g with GWT-Exporter but GWT.create didn't work HOT 4
- mvp4g for native app. HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mvp4g.