Code Monkey home page Code Monkey logo

Comments (11)

bravo-kernel avatar bravo-kernel commented on August 22, 2024

I can easily agree to your proposed modifications. There are two ways to make (default) file changes:

  1. using bash scripts from the cakebox project
  2. using the UpdateShell from the cakebox-console project, https://github.com/alt3/cakebox-console/blob/dev/src/Shell/UpdateShell.php

I forgot about the second option to be honest but we added that to make PR'ing these sort of system tweaks easier, no bash skills needed. I think you will be able to propose a PR with your eyes closed.

Running a vagrant reload --provision already runs the UpdateShell so it should just work.

from cakebox.

bravo-kernel avatar bravo-kernel commented on August 22, 2024

IIRC the UpdateShell is launched here

# Run cakebox self-update

from cakebox.

bravo-kernel avatar bravo-kernel commented on August 22, 2024

@dereuromark the Bake template for the generated vhosts is found here. Feel free to PR your update (and other tunes you might find useful).

https://github.com/alt3/cakebox-console/blob/dev/src/Template/Bake/vhost_nginx.ctp

from cakebox.

dereuromark avatar dereuromark commented on August 22, 2024

Yeah https://github.com/alt3/cakebox-console/blob/dev/src/Template/Bake/vhost_nginx.ctp#L29 needs to be switched over to 7.2 once the upgrade is complete for example.

from cakebox.

bravo-kernel avatar bravo-kernel commented on August 22, 2024

Not really, it is already handled during the upgrade (e.g. 5 ref replaced by either 7.1 or 7.2).

I was hinting at the 2MB request.

from cakebox.

dereuromark avatar dereuromark commented on August 22, 2024

Gotcha

PS: Interesting, why it didnt fix it for me. But all right, I will retry.

from cakebox.

bravo-kernel avatar bravo-kernel commented on August 22, 2024

Probably due to a f** up on my behalf during progress but it is 100% reproducable for me now, works every single time.

If you have other improvements besides the 2MB feel free to stick them in the template.

from cakebox.

dereuromark avatar dereuromark commented on August 22, 2024

Well, the defaults for session and php post limit size in general are bad for developing :)
I have to adjust them every time too, but maybe out of scope.

sudo sed -i 's|upload_max_filesize = 2M|upload_max_filesize = 128M|g' /etc/php/7.2/fpm/php.ini
sudo sed -i 's|post_max_size = 8M|post_max_size = 128M|g' /etc/php/7.2/fpm/php.ini
sudo sed -i 's|session.gc_maxlifetime = 1440|session.gc_maxlifetime = 1440000|g' /etc/php/7.2/fpm/php.ini
sudo sed -i 's|memory_limit = 128M|memory_limit = 256M|g' /etc/php/7.2/fpm/php.ini

The 128M is important and useful if you use phpmyadmin and need to import a bigger SQL dump.
And it doesn't hurt to have it on such a high level anyway.

from cakebox.

bravo-kernel avatar bravo-kernel commented on August 22, 2024

I see, do these setting work on the (per) vhost level as well? If so it would be nice to add them all there. If people don't like them they can easily adjust per site.

from cakebox.

dereuromark avatar dereuromark commented on August 22, 2024

I dont think so, those need to be in the main php.ini for both CLI and WEB to work.

from cakebox.

bravo-kernel avatar bravo-kernel commented on August 22, 2024

OK, I will put this on the list for the next fix.

from cakebox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.