Code Monkey home page Code Monkey logo

Comments (5)

qwandor avatar qwandor commented on May 24, 2024

Sounds reasonable. It should be fairly straightforward to add a manufacturer data field to the DeviceInfo struct. We should probably also add a BluetoothSession::get_device_info method, similar to the existing get_service_info and so on, to get a single device rather than having to get them all with get_devices.

It looks like scan configuration is done by calling SetDiscoveryFilter on the adapter. This could be done by BluetoothSession::start_discovery or by a new method. We should probably also add a stop_discovery method as we don't yet have that.

Feel free to send a pull request, or else I can have a look tonight or this weekend.

from mijia-homie.

qwandor avatar qwandor commented on May 24, 2024

Oh, and it sounds like you also want a new DeviceEvent variant. I haven't looked into that yet.

from mijia-homie.

qwandor avatar qwandor commented on May 24, 2024

@MattesWhite Please take a look at #130 and see if it does what you want, and what you think of the code structure. If you give me a code review on that then I'll merge it and release a new version for you.

from mijia-homie.

MattesWhite avatar MattesWhite commented on May 24, 2024

Thanks a lot for the big amount of work you put into my request. I really didn't expected that much. As requested I reviewed the PR, don't have anything to complain about.

To finish things, I'll test the events example with my setup to acknowledge that everything works.

from mijia-homie.

qwandor avatar qwandor commented on May 24, 2024

Fixed by #130.

from mijia-homie.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.