Code Monkey home page Code Monkey logo

Comments (5)

alphapapa avatar alphapapa commented on July 19, 2024 1

Thank you, now I understand. I think your patch is the right way to do it. :)

from bufler.el.

alphapapa avatar alphapapa commented on July 19, 2024 1

BTW, for future reference, you should generally propose PRs from a branch on your fork rather than from your master branch. That makes it safer for me to push amendments before merging.

from bufler.el.

alphapapa avatar alphapapa commented on July 19, 2024

Unfortunately I don't see a straightforward way to fix that with pretty-hydra.

Fortunately, there seem to be two simple workarounds:

  • Press q to exit the Hydra.
  • Don't press ? while in the Hydra.

from bufler.el.

alphapapa avatar alphapapa commented on July 19, 2024

Copying my comment from the PR:

That changes the fundamental behavior of the hydra so that any action exits the hydra. It also turns ? into the key to exit the hydra, which it is not intended to be. Finally, I'm not sure if calling quit-window directly will always work correctly.

I appreciate the patch, but I don't think this is the way to go.

Would you explain why you think this issue even needs to be fixed? ? is not listed as a valid key in the hydra, and users who press it by accident can simply press q to exit the hydra. I don't think this is a significant problem.

from bufler.el.

lerouxrgd avatar lerouxrgd commented on July 19, 2024

Indeed it changes a bit the behavior of the hydra which is why I wanted to hear your opinion about it. I am not a power user of hydra in general but I am quite used to the behavior of the one from treemacs. And this is what this PR tries to imitate, however this was just a suggestion.

As for why I think the current behavior is odd and should be fixed, well I can easily run into situations where the hydra sticks around. The workflow I described above is one way, another one could be:

  • Run bufler
  • Press ? to open hydra help
  • Press RETto switch to the selected buffer, then it switches buffer but the hydra sticks around. If I press q to quit it, then the buffer is switched back to the previous one. If I press anything else, I get the message: Wrong type argument: (or eieio-object class), nil, obj.

from bufler.el.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.