Comments (1)
Having just thought about this a bit more, I'm not sure the attachments should be marked as deleted when a policy group is deleted.
A policy group is immediately public when it is created. Similarly attachments on a policy group are immediately public when they are added to the policy group.
If we think of policy group creation as the equivalent of the publishing of an edition, and policy group destruction as the equivalent of the un-publishing of an edition, it could be argued that the attachments should stay visible when the policy group is destroyed. Or at least the attachment URLs should still do something sensible, e.g. redirect to some kind of "un-publishing page".
It looks as if policy groups are published via the Publishing API, so perhaps there is a mechanism to display some kind of "un-publishing page" when a policy group is destroyed.
Anyway, I'm not planning to look into this any further at this stage.
from whitehall.
Related Issues (20)
- Remove commit - Content for "theresa-may" missing HOT 1
- Missing Local data - images HOT 1
- Running tests results 404 API error HOT 1
- Bad file descriptor (Errno::EBADF) - individual tests HOT 3
- Missing local data - World Locations HOT 3
- Page failing to render locally - Announcements HOT 1
- Broken link reporter test HOT 1
- Announcements page - content HOT 1
- Consider replacing IDs with data-* attributes HOT 1
- Pluralisations quirk will cause fallbacks to English locale
- Prevent ministers and officials from hiding substantial policy paper changes as minor HOT 5
- Add View Components HOT 5
- Remove obsolete PDF thumbnail generation feature and Ghostscript dependency HOT 2
- Links in component guide are broken
- When updating a slug for an edition, trailing spaces cause a crash
- Topical Events logos cannot be SVGs
- Advisory text for custom organisation logos appears to be incorrect
- Lack of checking for duplicate titles/URLs
- 'Back' link doesn't work in organisation pages, Promotional Feature
- Pre-rendered attachment markup can be removed from content items
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from whitehall.