SQL select with Alaises about phpsoda HOT 6 CLOSED

The spaces in the "AS" clauses is confirmed

While trying the case "Not all column names must have an alias", the column given without alias are generated like origin AS , file_type AS, year as publication_year instead of origin, file_type, year as publication_year

I can't reproduce this behavior, do you have another snippet that shows it? Currently the ternary is checking if the key is a string where "origin" and "file_type" would give me integer keys.

$selectWithAliases = array(
  "origin",
  "file_type",
  "year" => "publication_year"
);

This is what I'm testing on PHP 7.1.6, is this an inconsistency in PHP versions?

$soql = new SoqlQuery();
$soql->select(array(
    'origin',
    'file_type',
    'year' => 'publication_year'
));

// $select=origin,file_type,year AS publication_year
$result = (string)$soql;

from phpsoda.

Hi,
Thank you for your immediate response.

With respect to point 2:
We are actually using a YAML SQL file and we parse the YAML file using symfony https://symfony.com/doc/current/components/yaml/yaml_format.html

We were not able to generate an array with mix of (key=>value and value) with the parser. We could only generate an array with (key=>value and key=> null) .

It would be great if you can add this additional check to handle the same. Also, let us know if you have any alternative approach to this problem.

from phpsoda.

What's the generated structure look like from Symfony? I'm cool with adding the additional check 👍 Probably just need to convert it into an if statement since the nested ternaries are getting hard to understand

from phpsoda.

It generates the following array formats:

1. array( "value", "value", "value");
2. array("key" => "value" , "key" => "value");
3. array("key" => null, "key" => "value");

We tried the combination of array("key" => "value" , "value") but Symfony is not able to recognize this format.

from phpsoda.

Ah, that makes sense. In your PR, could you do the following and I'll merge it in:

1. Add unit tests to test against both array structures:

   array(
     "origin",
     "file_type",
     "year" => "publication_year"
   );

   and

   array(
     "origin" => null,
     "file_type" => null,
     "year" => "publication_year"
   );

2. Split up the nested ternaries into an if statement. Something like this?

   if (is_string($key) && !is_null($value))
   {
       $formattedValues[] = rawurlencode(sprintf($format, trim($key), trim($value)));
   }
   else
   {
       $formattedValues[] = is_string($key) ? $key : $value;
   }

from phpsoda.

I have completed the above. Hope the test cases are fine.
Thanks

from phpsoda.