tile and key API params could be included in JSON data. <

On my PR <a class="issue-link js-issue-link" data-error-text="Failed to load title" da

Simplify API about tipboard HOT 4 OPEN

allegro commented on July 18, 2024

Simplify API

from tipboard.

Comments (4)

xor-xor commented on July 18, 2024

👍

from tipboard.

RickyGrassmuck commented on July 18, 2024

Saw you had this issue open, I just patched tipboard to use a single JSON object for retrieving the tile, key and data. Want me to submit a pull request so you can look it over?

from tipboard.

commented on July 18, 2024

Sure, I'd like to take a look :)

from tipboard.

the-maux commented on July 18, 2024

On my PR #70 i resolved this issue with a /update

For example, before, your data for the request was:

  var = {"tile": "big_value",
           "key":  "mybigvalue",
           "data": {"title": "% of something",
                               "description": "% of subtitle",
                               "big-value": "50%",
                               "lower-left-label": "title_value1:",
                               "upper-left-label": "title_value2:",
                               "upper-right-label": "value1",
                               "lower-right-label": "value2"}
         }

It's now:

  var = {"tile": "big_value",
           "key":  "mybigvalue",
           "value": {"big_value_color": "green", "fading_background": "true"},
           "data": {"title": "% of something",
                               "description": "% of subtitle",
                               "big-value": "50%",
                               "lower-left-label": "title_value1:",
                               "upper-left-label": "title_value2:",
                               "upper-right-label": "value1",
                               "lower-right-label": "value2"}
           }