Comments (6)
-
I concur. For first step metric per shard should be enough but we will expose them in aggregated form.
-
So we need to add stats struct to cache shard and update values with
sync.Atomic
-
How about formalized structure instead of map? e,g.: For the first step, I'll stick with Hits and Misses only.
type Stats struct { Hits uint64 Misses uint64 }
from bigcache.
3/3 👍 soon I'll push the changes.
from bigcache.
Fixed by #57
from bigcache.
I'd love to merge it!
We need to answer following questions:
- Are we going to collect global hit and miss or per each key?
- Where do we store the data?
- How do we want to expose this metric?
I'd prefer to not use any external libs in this project. Hits&Miss could be implemented as a simple counter.
from bigcache.
Nononono, no external libs :)
- I think per-key will be too heavy, at least for 1st implementation.
- Per shard in map, I'm not sure about
sync.Map
'cause collecting stats is more write oriented, butsync.Map
is more for read oriented. - WDYT about
cache.Stats() map[string]int64
? and keys of this map arehits
,misses
,avgShardSize
(just an example)
from bigcache.
- I forgot about
sync.Atomic
, all our counters are int64 which is quite obvious. So no locks or smth for stats, and we'll create a map only oncache.Stats()
which is great.
from bigcache.
Related Issues (20)
- Excessive memory allocation HOT 1
- The index(int) of entries(queue.BytesQueue) overflows the hashmap's uint32 value HOT 4
- Memory so high, and when clean not reduce size HOT 5
- Benchmark is not fair, So the speed can't be trusted HOT 4
- Whether it is a bug ? HOT 1
- Why doesn't bigcache consider designing expiration time for each cache key? HOT 4
- How does bigcache handle hash collisions HOT 1
- BigCache is logging allocations it should not HOT 4
- Support for the map? HOT 1
- compile a 32-bit LSB executable on arm and Execution error-> panic: unaligned 64-bit atomic operation HOT 6
- Is there a memory leak in bigcache? HOT 4
- Add multi-level cache design HOT 2
- Why do we need to configure both lifeWindow and cleanWindow? HOT 2
- GRPC server support HOT 4
- feature: Support uint64 keys without converting to string then back again HOT 6
- Proposal to Integrate SIEVE Eviction Algorithm
- potential misuse of reflect function
- Unused parameter in shards.go [ DEL ] HOT 4
- Improve error handling in BytesQueue.Push function in queue.go HOT 2
- A panic occurred, causing the lock to remain engaged.panic: makeslice: len out of range
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bigcache.