Code Monkey home page Code Monkey logo

Comments (4)

lahavsavir avatar lahavsavir commented on June 16, 2024 1

from clisso.

 avatar commented on June 16, 2024

As this is one of the most requested features internally, I'll try to advance this.

I wonder if a shared embeddable token is considered a security risk again? @lahavsavir

Compared to the previous internal solution, this removes the possibility to list users but still keeps the possibility to enumerate apps if I know the email addresses of users (which are incredible hard to guess).

Alternatives I see is developing some Lambda that is storing the needed credentials securely and can only be used after authentication (I'd prefer IAM based auth).

@lahavsavir, @johananl WDYT?

from clisso.

johananl avatar johananl commented on June 16, 2024

Looks like the embed token is much safer than the API credentials, because all it allows you to do is obtain the list of apps. On the other hand, it still allows obtaining a list of apps without providing user credentials, MFA etc. It also allows a user to get a list of apps that are accessible to another user by sending a request to the API with their email address (and the same token), however it won't allow them to get credentials for these apps if they themselves don't have permissions for them.

The question is if the above is acceptable. It might be acceptable for some use cases.

Looks like the embed token is shared by design, i.e. you can't even generate two on a given OneLogin account, only replace the one existing token.

A Lambda-based solution seems outside the scope of Clisso to me. All Clisso provides is an interface to OneLogin/Okta. This could still be a valid solution for specific use cases, however I don't see how Lambda helps us provide a generic solution to the app ID retrieval issue.

REMINDER: This is a public repository now. We should avoid discussing specifics or "internal" stuff. For these we should use other channels. Just a reminder because this discussion could lead to sensitive issues.

from clisso.

johananl avatar johananl commented on June 16, 2024

How about talking to OneLogin about this use case? We need some solution which would eliminate the need for contacting an admin for every app a user wants to add, without creating huge security risks. They might have an idea. If they don't, we could try pushing towards a new feature.

from clisso.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.