Code Monkey home page Code Monkey logo

Comments (2)

elipousson avatar elipousson commented on May 18, 2024

The package is still kicking back a note and two warnings:

  • Note: "Found if() conditions comparing class() to string"
  • Significant warning: "utilities.cpp:186:26: warning: bitwise or with non-zero value always evaluates to true [-Wtautological-bitwise-compare]"
  • Additional warning: "Non-staged installation was used"

I started addressing the note by replacing class(pdf) == "character" with rlang::is_character() with the assumption that an additional dependency for rlang should be fine if you are already importing ggplot2. I'd also be glad to convert the stop() errors into abort() or (if you're OK with adding a dependency on cli) cli::cli_abort(). Again, happy to handle these in a separate pull request or avoid adding these additional dependencies altogether if you prefer.

from pdfr.

AllanCameron avatar AllanCameron commented on May 18, 2024

Hi Eli

Thanks very much for this. I had rather given up developing this package as you can probably tell. I will have to re familiarise myself with the code base. Please do open a pull request; I'm very happy to have your input

Allan

from pdfr.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.