aws 23.0.0: broken build on Fedora about alire HOT 4 OPEN

Some notes when trying to spot the issue.... It is not related to Fedora and it occurs on other systems. I've created a blank project that only with aws and at some point I got the following error:

   [mkdir]        object directory for project Valhalla
   [mkdir]        exec directory for project Valhalla
src.gpr:39:37: "../.build/x86_64-pc-linux-gnu/setup/src" is not a valid directory
gprbuild: "/src/vacs/valhalla/valhalla.gpr" processing failed
error: Command ["gprbuild", "-s", "-j0", "-p", "-P", "/src/vacs/valhalla/valhalla.gpr"] exited with code 4
error: Compilation failed.

Looking at the cache/dependencies/aws_23.0.0_6c406859/.build directory, it contained a
x86_64-linux-gnu and another x86_64-pc-linux-gnu directory. The src directory was generated in x86_64-linux-gnu. The makefile.setup was created with the line:

TARGET=x86_64-linux-gnu

but the AWS toml configuration is defined with:

TARGET = "x86_64-pc-linux-gnu"

I think the root issue is that when we run the AWS post-fetch setup command, we don't give the TARGET configuration. It means the configuration is made by using AWS default which is:

TARGET = $(shell gcc -dumpmachine)

When Alire uses its own compiler, you get:

~/.config/alire/cache/dependencies/gnat_native_12.1.2_66b989b5/bin/gcc -dumpmachine
x86_64-pc-linux-gnu

But if you use some system default, you get:

/usr/bin/gcc -dumpmachine
x86_64-linux-gnu

which means that depending on your PATH and which compiler you use and/or is installed on the system by default, we can get different results.

@Fabien-Chouteau , to solve this issue, we could change the post-fetch action to:

command = ["make", "setup", "ZLIB=false", "DEMOS=false",
           "LAL=false", "XMLADA=false", "SOCKET=openssl", "prefix=install_dir",
           "PRJ_BUILD=Release", TARGET="x86_64-pc-linux-gnu"]

which also means there must be specific post-fetch actions for each target.

This explains the failure of Ada Utility Library AWS 2.6.0 crate for Debian and Fedora (it's ok for Arch and Ubuntu latest).

from alire.

@Fabien-Chouteau and @mosteo, I think the root issue comes from the script https://github.com/alire-project/alire-index-checks/blob/stable-1.2.1/scripts/gh-build-crate.sh.

What happens is that the alr dependencies are run first with a default compiler in the PATH (/usr/bin/gcc probably).

Then, we seem to select a different compiler with alr toolchain --select and a different compiler is used: the TARGET is changed but the setup scripts have been executed.

from alire.