Clarification/improvement of INCLUDE_DIR component in buckets about aliceo2 HOT 4 CLOSED

I did some investigation regarding this issue. If the dependency is a bucket, also all the (system)include directories are recursively retrieved in GET_BUCKET_CONTENT and added to the includes of a module.

Another case is probably if the dependency is a library from a different module of the same project. Like e.g. the Field module/library which is a dependency for tpc_simulation_bucket. Here also the include
path is added explicitly in the INCLUDE section. I suppose this is exactly for the reason of this issue.

However, removing the path from the include does not have any effect on the dictionary generation, it is generated without problems.

Maybe this issue is solved, what do you think @sawenzel ?

Side remark: What is not yet clear to me is how the include path of another internal module which has been specified as dependency makes it to the list of include directories. There are only three occurrences of target_include_directories in O2Utils.txt, but none of them seems to do this. Maybe some cmake magic connected to target_link_libraries when the dependencies are known internally.

from aliceo2.

@matthiasrichter
Concerning the side remark : yes, as far as I know, it is some CMake magic that works when dependencies are built and known internally.

from aliceo2.

@matthiasrichter : Thanks for the explanation. This means that we might be able to cleanup our bucket definitions quite a lot.

from aliceo2.

Closing this as I understand this is understood. Feel free to reopen if not the case.

from aliceo2.