Pull request verification fails with unrelated error about aliceo2 HOT 3 CLOSED

Hello,
The problem is created by a38bba7 :
in Generators/include/Generators/Pythia8Generator.h
-#include "Pythia8/Pythia.h" // for Pythia
+#include "Pythia.h" // for Pythia

The dictionary is generated with -I/home/shahoian/alice/sw/ubuntu1604_x86-64/pythia/v8211pre-1/include while the Pythia.h is in /home/shahoian/alice/sw/ubuntu1604_x86-64/pythia/v8211pre-1/include/Pythia8. @MohammadAlTurany , it seems the O2Dependencies.cmake should be modified but I don't know how.

Cheers,
Ruben

from aliceo2.

Indeed commit a38bba7 is the problem here plus the fact that o2.sh recipe sets PYTHIA8_INCLUDE_DIR to
${PYTHIA_ROOT:+-DPYTHIA8_INCLUDE_DIR=$PYTHIA_ROOT/include}. This is a clear contradiction.

Since this is a blocker for the PR tests now, I am in favour of going back to include "Pythia8/Pythia.h".

from aliceo2.

See PR #252.

Another argument to stick with "Pythia8/Pythia.h" is the fact that the Pythia.h header itself uses this convention. So we should really have "$PYTHIA_ROOT/include" as include dir otherwise Pythia.h will not find its sub-headers.

from aliceo2.