Intermittent panic when go test with -coverpkg about miniredis HOT 7 CLOSED

Since you give a fixed port there can't be multiple (mini)redises running at the same time, but go test runs separate packages in parallel by default. Try running go test with: go test -p=1 etc, so it'll only run a single test at the same time.

It works! Thanks a lot

from miniredis.

from miniredis.

/go/pkg/mod/github.com/alicebob/miniredis/[email protected]/server/server.go:122 +0x3c

That's https://github.com/alicebob/miniredis/blob/master/server/server.go#L122

s.mu.Lock()

I don't get the error locally, and looking at the code, might it be that you start a redis server in a Go routine, and it's not ready starting yet when you use it? Would it otherwise be possible to make a standalone test case?

from miniredis.

@alicebob Thanks for investigation! I didn't start redis on go routine, instead I put it on a init() func, and start on a fixed port.

		if addr != "" {
			return addr, "", 0, tls, nil
		}
		log.Info().Msg("No redis set on env, start mini redis.")

		mr := miniredis.NewMiniRedis()
		mr.StartAddr(":15678")

		addr = mr.Addr()
		return addr, "", 0, tls, nil

That's very strange, I met the panic only if set -coverpkg=./... on go test

from miniredis.

from miniredis.

Since you give a fixed port there can't be multiple (mini)redises running at the same time, but go test runs separate packages in parallel by default. Try running go test with: go test -p=1 etc, so it'll only run a single test at the same time.

from miniredis.

@alicebob aha, got the errMsg

panic: listen tcp :15678: bind: address already in use

It seems -coverpkg=./... makes the tests run concurrence between different package.

from miniredis.