Unify image customization methods in the core Helm chart about higress HOT 5 CLOSED

i think i can fix this. Please assign it to me.

However, this change will break the compatibility. @johnlanni , what do you think?

I've talked to @johnlanni . He's OK with this. @Uncle-Justice , please go ahead. Thanks.

from higress.

Is the difference now caused by the different ways of setting in values.yaml?

If so, i think we can first unify the formats of coressponding fields like hub and image for these three containers in values.yaml, then we can easily unify this issue.

For example:

image: "{{ .Values.controller.hub | default .Values.global.hub }}/{{ .Values.controller.image | default "controller" }}:{{ .Values.controller.tag | default .Chart.AppVersion }}"
image: "{{ .Values.pilot.hub | default .Values.global.hub }}/{{ .Values.pilot.image | default "pilot" }}:{{ .Values.pilot.tag | default .Chart.AppVersion }}"
image: "{{ .Values.gateway.hub | default .Values.global.hub }}/{{ .Values.gateway.image | default "gateway" }}:{{ .Values.gateway.tag | default .Chart.AppVersion }}"

from higress.

Is the difference now caused by the different ways of setting in values.yaml?

Yes. And I'm OK with the example you gave to fix this issue.

from higress.

i think i can fix this. Please assign it to me.

from higress.

i think i can fix this. Please assign it to me.

However, this change will break the compatibility. @johnlanni , what do you think?

from higress.