Comments (3)
Hello @xnth97 and thank you for pointing out my mistake :)
I've seen your pull request. I'll check it tomorrow and merge it if everything is ok.
from tltagscontrol.
@ali312 Thanks for reply and your great work! I do like your code and it's my pleasure to have the chance to contribute to it.
And sorry that I made a mistake in Sample (Line 84, ViewController.m). I didn't notice that all the tags of TagsControls point to one single NSMutableArray so it may crash if you tap on tags after editing others. Also one single NSMutableArray may cause other crashes while editing tags (for instance, first delete the last tag of _defauldEditingTagControl, then try to delete the last tag of _blueEditingTagControl.tags, it will crash). So I suggest to use _defauldEditingTagControl.tags = [tags mutableCopy] instead of _defauldEditingTagControl.tags = tags directly, it may fix all crashes in Sample.
btw _defauldEditingTagControl -> _defaultEditingTagControl another spelling mistake :P
from tltagscontrol.
Hello again @xnth97,
Sorry for such a late reply. I was busy at work lately.
I've merged your pull request.
Thank you for your contribution, I really appreciate that.
from tltagscontrol.
Related Issues (20)
- Wrap tags HOT 1
- isFirstResponder HOT 2
- Scrolling Issue. HOT 6
- Using Storyboard and creating tagArray....
- Cannot remove tags programmatically. Decide to add tag or not after pressing return key. HOT 5
- Tag added/removed events
- Unable to find a specification for `TLTagsControl`
- Move scoll up problem
- not working in IOS10
- validating tags without pressing return key
- [SUGGESTION] - Carthage
- Can not remove/ add new tags in swift.
- Scroll stuck when scrolling list tagviews HOT 3
- Layer Issue
- Issue while using tagview mode edit in tableview cell
- RTL Support
- Application crashed on selection of delete Tag HOT 2
- Add cocoapod spec, pls? HOT 2
- Support Edit tag function HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tltagscontrol.