Code Monkey home page Code Monkey logo

Comments (11)

Alhadis avatar Alhadis commented on August 15, 2024 2

OH! Shit, I know what's going on. It's because these lines are assuming the browser supports the second argument of classList.toggle. Which IE never supported. Basically, this lets you add/remove a class based on whether the second argument (if provided) evaluates to true or false.

Which I failed to notice because I'd been using a bundle of polyfills for IE which fixes that. Of course, it's my fault that I forgot it mightn't always be available...

I'll address this and follow up with a patch release. In the meantime, you can use this to fix the lack of full .toggle support in IE 11.

from accordion.

Alhadis avatar Alhadis commented on August 15, 2024

Hi @mathishuettl,

Yes, it does work on Internet Explorer. You'll need to be much more specific as to what you mean by "not working". What version of IE are you referring to?

from accordion.

mathishuettl avatar mathishuettl commented on August 15, 2024

Hello,

thanks for you quick reply. I use IE 11.
Look at my Link then you will see it. The Accordion titles are not clickable as example.

from accordion.

Alhadis avatar Alhadis commented on August 15, 2024

This seems to be a layout issue:

.product_container{
	width: 50%;
	float: left;
	padding: 15px;
}

I can't see a clearfix anywhere. Try adding this to your stylesheet:

 .accordion-inner::after{
	content: "";
	display: block;
	clear: both;
}

The accordion is working on IE11: it's just that it hasn't been able to calculate the boundaries of each section's contents correctly.

from accordion.

mathishuettl avatar mathishuettl commented on August 15, 2024

okay i added a clearfix but i have the same problem...

from accordion.

Alhadis avatar Alhadis commented on August 15, 2024

You added different code to what I recommended...

Does this happen if you delete this line?

 .product_container{
 	width: 50%;
-	float: left;
 	padding: 15px;
 }

from accordion.

mathishuettl avatar mathishuettl commented on August 15, 2024

It's still not as expected. I made the change you can check it here:
http://p408166.mittwaldserver.info/produkte/?taxonomy=productcategory&termID=3

from accordion.

Alhadis avatar Alhadis commented on August 15, 2024

Ah, I see what the problem is. For some reason, the accordion class is missing from the outermost container:

Figure 1

Whereas in Chrome, the class is there:

Figure 2

Make sure the accordion class is added for all browsers, and this problem should disappear. =)

from accordion.

mathishuettl avatar mathishuettl commented on August 15, 2024

Hello,

thanks for this good tipp, but I display the class for all browsers... when I watch the source of the page in IE there is the accordion class so I think it gets removed from any javascript, but I don't touch it.

from accordion.

mathishuettl avatar mathishuettl commented on August 15, 2024

Thank you!!

from accordion.

Alhadis avatar Alhadis commented on August 15, 2024

@mathishuettl Sorry for the long wait, I didn't mean for "a few days" to snowball into an entire week.

This has been released and published as v2.1.1. Thanks again for bringing this up; please let me know if you encounter any more difficulties in future. =)

from accordion.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.