Variables in script.js might get over-written about algorithm-visualizer HOT 10 CLOSED

@parkjs814 take a look at the sources here https://skalman.github.io/UglifyJS-online/
This person made a wrapper around uglify to make it run client-side.

from algorithm-visualizer.

No worries about it :)
I have removed those dependencies while I implement multiple tracers.
Check out the dev branch. (I'm still working on it.)

from algorithm-visualizer.

I figured out that we don't even need to use uglify.
I just moved all the global variables into an anonymous function, and changed all references to it.

fixed at ceadfa4

from algorithm-visualizer.

Mhm, that can be a problem. Great point. In which way are you fixing this issue?

from algorithm-visualizer.

I'm a bit confused at this point. The simplest way is to use Watch points, but they are not suitable for production.
I'm also looking into this

The problem is that variables like codeEditor, dataEditor, etc. (who are susceptible) are global. So no matter where you execute eval() from, it WILL overwrite the variables of the same name.

from algorithm-visualizer.

How do you think about uglifying the code internally before eval() it?
Then all the names of variables will have one or two letters, so that the global variables will not be overwritten.

from algorithm-visualizer.

You're right! we can do that.
But we can't uglify the variables tracer and G (in case of Graph algorithms) because these are then being used by script.js. We rely on eval () to create these 2 variables in the global scope so we can use them.
But otherwise it seems like a very good solution

from algorithm-visualizer.

I was looking for uglifying library for the client side, but it seems most of them are for node.js.
Do you know any?

from algorithm-visualizer.

This seems fantastic. But its not solving the issue, i.e., all variable names remain intact even after the minification.

from algorithm-visualizer.

That's not a big deal. We can just avoid short-named variables.
What I'm worrying about is that it could lower the performance of realtime-rendering.

from algorithm-visualizer.