Expose reserved areas about custom-qr-generator HOT 15 CLOSED

You can set highlighting for important areas using highlighting block in DSL builder.

from custom-qr-generator.

Ok thanks, I'll check that later. But I think it is something different. My background is already white.
I want single pixels to have that bright color, but none of the important pixels.
I could easily do this if the additional parameter was exposed.
And my solution would also allow for even more customization like having squares for the alignment patterns while having circles for the rest etc...

from custom-qr-generator.

It allows to set different shape and color for pixels from important areas. But its customization is limited. It probably can be extended

from custom-qr-generator.

The paint method of QrVectorColor ... should have an additional input parameter that gives some extra information about the current pixel.

It is impossible because in most of cases paint created for the whole dark/light pixels at once (not for one pixel). And QrVectorColor is a common interface for all types of paints like frames, balls, etc. May be it can provide info about the current component in general

from custom-qr-generator.

Makes sense. In theory wouldn't it be possible to just set this parameter to null/false/unavailable or something like that for all cases where all pixels are drawn at once?
But I am not too deep into your code, maybe there are more elegant solutions.

from custom-qr-generator.

Hi,
I now tried if the highlighting feature helps. But all I could achieve was that the pixels that are white anyway are highlighted now in a specific color. (purple in this example)
What I wanted to do though is to ensure that specific pixels are always black even though a color was used for the dark pixels (yellow in this example).

I also noticed that the 1 pixel frame of the version eye vanishes completely when highlighting is used. It doesn't really matter though as it doesn't help me in my situation anyway.

from custom-qr-generator.

I am actually very close now.
I changed my approach to have all dark pixels dark and add the accent color in the bright pixels.
So instead of turning some of the black pixels to yellow I turn some of the white pixels to yellow.
The highlighting feature can then be used to ensure some pixels stay white.
This way I was able to protect the eyes and the timing pattern, but I can't get the version eyes to look correct, as the highlight also overrides some of the dark pixels (the frame of the version eye).

from custom-qr-generator.

Highlighting will be extended in the next version and will allow to set shape and color of the highlighting as well as shape and color of the element being highlighted

from custom-qr-generator.

Currently shape of version eye aka alignment pattern is combined from frame and ball of corner eyes as well as its color as far as i remember

from custom-qr-generator.

the 1 pixel frame of the version eye vanishes completely

It is a result of applying rounded corner shape designed for 7-pixel eye to 5-pixel eye (bug). It works fine with other frame shapes

from custom-qr-generator.

This should help in 2.0.0-alpha01 if you rollback to random colors in dark pixels

highlighting {
    timingLines = HighlightingType.Styled(
        color = QrVectorColor.Unspecified,
        elementShape = /*your dark pixel shape goes here*/,
        elementColor =  /*your dark pixel color without randomness goes here*/
    )
    versionEyes = HighlightingType.Styled(
        color = QrVectorColor.Unspecified,
        elementShape = QrVersionEyeShape(
            frame = QrVectorFrameShape.AsPixelShape(
                pixelShape = /*your dark pixel shape goes here. */,
                size = 5
            ),
            ball = /*your dark pixel shape goes here. 
                   you can use same ball shape or call pixelShape.asBallShape() */
        ),

        elementColor =  /*your dark pixel color without randomness goes here*/
    )
}

from custom-qr-generator.

Hi,
I tried to implement the changes, but had to leave for work before I was finished.
As I use the library from within java, my implementation alway looks a bit different.
Timing pattern highlight already worked like a charm!
I was about to do the versionEye highlight when I had to leave. But it seemed there was no QrVersionEyeShape() at all.
Anyway, I'll work on it again tomorrow.
Thanks for all your help!

from custom-qr-generator.

it seemed there was no QrVersionEyeShape() at all.

It's a function from QrHighlighting.kt so you have to use QrHighlightingKt.QrVersionEyeShape i guess

from custom-qr-generator.

.asBallShape() is an extension from QVectorShapeUtils.kt (withourt 'r', wrongly named, will be changed)

from custom-qr-generator.

Hi,
everything works as expected!!
Thanks!

from custom-qr-generator.