Ensure output metadata is complete about scpca-nf HOT 5 CLOSED

I think that would all be appropriate to add. I don't think we expose everything in those outputs on the front end, but having extra things in the json should not cause any trouble.

The main purpose if this file is to populate front end fields. It is not part of the download directly, but it is compiled into a table for the download, which we could expand.

from scpca-nf.

It is not part of the download directly, but it is compiled into a table for the download, which we could expand.

From what I see, the values are not all exposed in the portal, but they are all in the TSV download.. are we saying the same thing?
For example for SCPCS000018 (nothing special about this sample other than it's a small file size and was quick..) -
single_cell_metadata.tsv.txt

from scpca-nf.

I see we have normalization information in there, but not scpca filter.

I did not read this carefully enough! We do have scpca_filter_method, but it's called cell_filtering_method. Therefore...

• This should probably be renamed rna_filtering_method. But, I'm wary of making that kind of a change (in part because of pending cite-seq-only portal updates..)
• We can still have an adt_filtering_method in there even though that one isn't called rna!

from scpca-nf.

I see we have normalization information in there, but not scpca filter.

I did not read this carefully enough! We do have scpca_filter_method, but it's called cell_filtering_method. Therefore...

• This should probably be renamed rna_filtering_method. But, I'm wary of making that kind of a change (in part because of pending cite-seq-only portal updates..)
• We can still have an adt_filtering_method in there even though that one isn't called rna!

I think this is fine, since the cell filtering we actually do is based on the RNA, so the name still fits.

from scpca-nf.

Closed with #361

from scpca-nf.