Comments (2)
I believe it'd read $object->some_date
instead of being appended to $object->order_at
, but I could be wrong..
// Model
protected $dates = ['ordered_at', 'created_at', 'updated_at']
public function getSomeDateAttribute()
{
return $this->ordered_at->format('m-d');
}
// View
{{ $object->ordered_at->toDateString() }}
{{ $object->some_date }}
Here's what I'd expect
https://laravel.com/docs/5.8/eloquent-mutators#defining-an-accessor
from laravel-best-practices.
@CarterBland @clemblanco True, it should be $object->some_date
to actually access the accessor. $object->ordered_at
will simply return a Carbon instance.
This example also lacks understanding from many perspectives.
- It makes no sense to call
$object->ordered_at->toDateString()
if there was no format applied. - It would make no sense to override the attribute
ordered_at
withgetOrderedAtAttribute
where the original value ofordered_at
becomes inaccessible on first sight. This could be solved by using$object->attributes['ordered_at']
, but that is the raw state of the attribute which only makes sense if it is intentional.
If 3 dates are available, and to format one date, it should be named similar to the original attribute, e.g.
protected $dates = ['ordered_at', 'created_at', 'updated_at']
public function getOrderedAtFormatAttribute()
{
return $this->ordered_at->format('m-d');
}
// View
{{ $object->ordered_at_format }}
{{ $object->ordered_at_format->toDateString() }}
from laravel-best-practices.
Related Issues (20)
- What PHP to JS package is recommended? HOT 4
- How about throw exceptions? HOT 5
- Do not get data from the .env file directly, why? HOT 2
- What about laravel Resources? HOT 3
- Wrong return type? HOT 1
- PSR-12 HOT 3
- What about translation variables? HOT 2
- Best
- Interface best practice HOT 5
- Converting from and back to json HOT 1
- Validation FormRequest HOT 1
- Looking for the repo owner HOT 8
- Typo Issue in example (Don't repeat yourself (DRY)) HOT 2
- Store dates in the standard format. Use accessors and mutators to modify date format HOT 11
- Seeder in singular -> Good, Seeder in plural -> bad (naming-conventions) HOT 2
- Recommended route name conflict?
- A tool that enforces all these best practices HOT 1
- Change test case methods to snake_case HOT 1
- Query Parameter Validation HOT 1
- La
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from laravel-best-practices.