Last line of blame doesn't appear about git-blame HOT 6 CLOSED

I'll fix this one. Looking into it now.

from git-blame.

Reverted to my original regex pattern in the commit above. fixes issue. will be adding unit test coverage for this file.

from git-blame.

Sorry I wasn't watching the repo so I missed this. There was a tiny bug in my regex that caused this to fail for the last line if it didn't end with a \n but I have that fixed now.

I'd rather we use the new parsing rather than the original for the reasons that I explained in #21.
Oh, and I can go ahead and write some tests while I'm at it, too.

Want to reopen this issue or should I create another issue for this?

from git-blame.

I'll fix the bug in my regex as part of fixing issue #25

from git-blame.

I think the regex we have right now is fine and I havent noticed any performance issues with it. What were the advantages of yours again?

from git-blame.

@alexcorre, the main feature is that it is iterative so it can handle larger data sets with a smaller memory footprint.
I ran some tests with benchmark.js and it is about 2x faster which is probably due to the smaller memory footprint and perhaps the fact that the RegExp doesn't use a lookahead.

$ node test.js
RegExp split x 56,146 ops/sec ±0.80% (92 runs sampled)
RegExp iterative x 98,484 ops/sec ±0.45% (102 runs sampled)
Fastest is RegExp iterative

I have the fixed RegExp and a couple of tests if you'd like me to make another PR.
Just let me know.

from git-blame.