Comments (8)
Actually if you look at the less file you can see it does rely on existing classes. It never actually sets a text color. It does set background-color
, and even then by slightly darkening and lightening the @base-backgroud-color
.
In your screenshot I don't understand why the background is white if the rest of your editor is dark. What theme are you using?
from git-blame.
Ahh, I see the problem. I'm using Atom Light UI and Atom Dark Theme. So because you're using the UI's background color rather than the background color for the gutter (whatever that is) it doesn't work right when the UI and the theme are mismatched.
I haven't done any extension development, so I'm not sure what the style is for gutter, but git-blame ought to use the same.
It's a great extension! Thank you for the time you've spent creating and supporting it.
from git-blame.
I haven't looked at this is a while but as Desmond said it's not hard
coded. If the gutter background color is exposed we can switch to lighten
that one instead easily. Will take a look into this.
On Saturday, August 16, 2014, Jacob Wright [email protected] wrote:
Ahh, I see the problem. I'm using Atom Light UI and Atom Dark Theme. So
because you're using the UI's background color rather than the background
color for the gutter (whatever that is) it doesn't work right when the UI
and the theme are mismatched.I haven't done any extension development, so I'm not sure what the style
is for gutter, but git-blame ought to use the same.It's a great extension! Thank you for the time you've spent creating and
supporting it.ā
Reply to this email directly or view it on GitHub
#22 (comment).
Alex Corre
[email protected]
310.694.4325
from git-blame.
I briefly looked into this but didn't come up with anything I liked enough for a PR. Here's what I learnt in case you want to continue it @jacwright:
@import "syntax-variables"
will import the less variables used by the syntax theme. Right now we're doing @import "ui-variables"
which gives styles from the UI theme.
Once you @import "syntax-variables"
, you have a couple of relevant variables @syntax-gutter-background-color
and @syntax-gutter-text-color
. But there's not much else. And the rest of the 'default' style seem to be aligned with the UI theme, not the editor theme. For example, right now we are using the default styles for <a>
s and also the .text-hightlight
class. But both of these are aligned with the UI theme, not the editor theme.
from git-blame.
Thanks @dmnd! That will be a great help. I'll see what I can come up with.
from git-blame.
Hey @jacwright any ideas on a fix for this?
from git-blame.
I haven't looked into it. Things have been busy. I'll try and come back to it eventually.
from git-blame.
I added this in my ~/.atom/styles.less
:
atom-text-editor::shadow .git-blame-mount,
atom-text-editor .git-blame-mount {
@git-blame-bg-color: #222;
.git-blame .git-blame-scroller {
background-color: @git-blame-bg-color;
border: none;
.blame-lines .blame-line {
&.line-bg-lighter { background-color: lighten(@git-blame-bg-color, 4%); }
&.line-bg-darker { background-color: darken(@git-blame-bg-color, 4%); }
}
}
}
and it looks like this:
Maybe it will be helpful for someone.
from git-blame.
Related Issues (20)
- Gutter is empty after opening git blame HOT 12
- Gutter Readout Garbled HOT 1
- Add grouping of lines that belong to the same commit HOT 1
- Cannot read property 'replace' of null HOT 5
- Hover Tips sometimes get stuck HOT 1
- Gutter is broken HOT 3
- Doesn't support renames/copys with -C -C -Cā¦?
- Show commit authors in different colors HOT 10
- Gutter resize is Broken HOT 3
- Allow nested repositories HOT 1
- Cannot find 'highlights-component' in the require cache. HOT 1
- use es6 + lint on all files
- get off react-for-atom
- commit description tooltip remains present when gutter is closed HOT 2
- Can't see commit's author HOT 8
- Is the one getting installed alessioalex/git-blame HOT 2
- date color
- `git-blame` Unable to display content HOT 7
- Tooltip remains after window closes HOT 1
- Uncaught Error: Cannot find module 'babel-runtime/helpers/extends' HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
š Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ššš
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ā¤ļø Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from git-blame.